Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

test: move the pydantic check inside test - #1812

Merged
JoanFM merged 3 commits into
mainfrom
pull-stream-file
Sep 28, 2023
Merged

JoanFM merged 3 commits into
mainfrom
pull-stream-file

Conversation

@JoanFM

@JoanFM JoanFM commented Sep 28, 2023

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Sep 28, 2023 •

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (83d2236) 84.57% compared to head (f4f56c3) 84.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
+ Coverage   84.57%   84.61%   +0.04%     
==========================================
  Files         135      135              
  Lines        9004     9005       +1     
==========================================
+ Hits         7615     7620       +5     
+ Misses       1389     1385       -4     
Flag Coverage Δ
docarray 84.61% <90.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/store/helpers.py 60.55% <90.00%> (+0.36%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM
JoanFM force-pushed the pull-stream-file branch 2 times, most recently from 75ddeb4 to 87b0ffa Compare September 28, 2023 17:10
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-pull-stream-file--jina-docs.netlify.app 🎉

@JoanFM
JoanFM merged commit 9a6b1e6 into main Sep 28, 2023
@JoanFM
JoanFM deleted the pull-stream-file branch September 28, 2023 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pydantic v2] Push and pulling tests not passing with pydantic v2

1 participant