Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

refactor: use safe_issubclass - #1778

Merged
JoanFM merged 1 commit into
mainfrom
safe-is-subclass-more
Sep 6, 2023
Merged

JoanFM merged 1 commit into
mainfrom
safe-is-subclass-more

Conversation

@JoanFM

@JoanFM JoanFM commented Sep 6, 2023

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM
JoanFM force-pushed the safe-is-subclass-more branch from 805b78f to 3309b46 Compare September 6, 2023 15:59
@github-actions

github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-safe-is-subclass-more--jina-docs.netlify.app 🎉

@codecov

codecov Bot commented Sep 6, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -54.95% ⚠️

Comparison is base (189ff63) 84.99% compared to head (3309b46) 30.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1778       +/-   ##
===========================================
- Coverage   84.99%   30.05%   -54.95%     
===========================================
  Files         134      133        -1     
  Lines        8845     8738      -107     
===========================================
- Hits         7518     2626     -4892     
- Misses       1327     6112     +4785     
Flag Coverage Δ
docarray 30.05% <0.00%> (-54.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/array/doc_vec/doc_vec.py 20.94% <0.00%> (-66.90%) ⬇️
docarray/typing/tensor/abstract_tensor.py 65.64% <ø> (-25.77%) ⬇️

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM
JoanFM merged commit 08ca686 into main Sep 6, 2023
@JoanFM
JoanFM deleted the safe-is-subclass-more branch September 6, 2023 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants