Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

feat: add description and example to ID field of BaseDoc - #1737

Merged
JoanFM merged 4 commits into
mainfrom
feat-add-basedoc-id-example
Aug 1, 2023
Merged

JoanFM merged 4 commits into
mainfrom
feat-add-basedoc-id-example

Conversation

@JoanFM

@JoanFM JoanFM commented Jul 31, 2023

Copy link
Copy Markdown
Member

No description provided.

Joan Fontanals Martinez added 2 commits July 31, 2023 12:25
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@codecov

codecov Bot commented Jul 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +22.92% 🎉

Comparison is base (a643f6a) 61.53% compared to head (c1b4aa5) 84.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1737       +/-   ##
===========================================
+ Coverage   61.53%   84.46%   +22.92%     
===========================================
  Files         134      134               
  Lines        8840     8838        -2     
===========================================
+ Hits         5440     7465     +2025     
+ Misses       3400     1373     -2027     
Flag Coverage Δ
docarray 84.46% <100.00%> (+22.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/base_doc/doc.py 92.90% <100.00%> (+39.00%) ⬆️
docarray/index/backends/elastic.py 90.22% <100.00%> (+0.09%) ⬆️
docarray/index/backends/elasticv7.py 94.11% <100.00%> (-0.41%) ⬇️
docarray/index/backends/hnswlib.py 74.28% <100.00%> (+14.52%) ⬆️

... and 79 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM
JoanFM force-pushed the feat-add-basedoc-id-example branch from 5b2cb77 to 46bcf5a Compare July 31, 2023 15:53
@JoanFM
JoanFM force-pushed the feat-add-basedoc-id-example branch from e20feab to 7efbf1e Compare August 1, 2023 01:16
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM
JoanFM force-pushed the feat-add-basedoc-id-example branch from 7efbf1e to c1b4aa5 Compare August 1, 2023 01:27
@github-actions

github-actions Bot commented Aug 1, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-add-basedoc-id-example--jina-docs.netlify.app 🎉

@JoanFM
JoanFM merged commit 31c2bb9 into main Aug 1, 2023
@JoanFM
JoanFM deleted the feat-add-basedoc-id-example branch August 1, 2023 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants