Fix bad exclusion of messagebus configuration option in redis connection - #330
Merged
Merged
Conversation
henrik
added a commit
to henrik/message_bus
that referenced
this pull request
May 4, 2023
As discussed in discourse#330, an allowlist would be better still. This is preventing us from upgrading to Redis 5.
henrik
added a commit
to henrik/message_bus
that referenced
this pull request
Jun 28, 2023
As discussed in discourse#330, an allowlist would be better still. This is preventing us from upgrading to Redis 5.
Contributor
Author
|
@tgxworld Sorry to ping you on this one. I noticed you merged a similar PR Are you fine with me just adding a changelog entry to be able to merge this PR ? |
Contributor
|
Yes please :) Do add a changelog here and I'll be happy to merge this. |
Intrepidd
marked this pull request as ready for review
August 10, 2023 08:24
Contributor
Author
|
Done ! |
tgxworld
approved these changes
Aug 10, 2023
Contributor
|
Thank you @Intrepidd |
Contributor
Author
|
Thanks! Do you think this is worth cutting a patch level release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating just a DRAFT PR for now to get insights.
I discovered it is impossible to use the group ids lookup feature alongside the redis backend as there is a typo in the exclusion list.
As stated by the comment, we should probably allowlist the params to be passed to redis rather then exclude some known ones. Maybe even better would be to have them in a separate
redis_optionshash but this would kill backwards compatibility.Additionally, a regression spec is needed
Any idea which direction is preferred ?