Skip to content

4497: Use search for search inputs as enter key hint - #4501

Open
lunars97 wants to merge 3 commits into
mainfrom
4497-use-search-as-enter-key-hint-for-search
Open

4497: Use search for search inputs as enter key hint#4501
lunars97 wants to merge 3 commits into
mainfrom
4497-use-search-as-enter-key-hint-for-search

Conversation

@lunars97

@lunars97 lunars97 commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Short Description

This PR shows search key instead of enter key in keyboard for search inputs/fields.

Proposed Changes

  • Add enterKeyHint='search' for search fields
  • Leave others as it is while other input fields are multiline and having enter is semantically correct

Side Effects

N/A

Checklist

Testing

Go to search inputs in language change, search content, search region and click on input field and see the keyboard with search key. In android native and web it looks like 🔎 , in ios and macOS it has a blue search text key

Resolved Issues

Fixes: #4497

lunars97
lunars97 commented Oct 21, 2026
View reviewed changes
Comment thread native/src/components/base/InputSection.tsx
steffenkleinle
steffenkleinle approved these changes Oct 22, 2026
View reviewed changes

@steffenkleinle steffenkleinle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Tested on Android and iOS.

bahaaTuffaha
bahaaTuffaha approved these changes Oct 22, 2026
View reviewed changes

@bahaaTuffaha bahaaTuffaha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and Android ✅

  • I think you need to add a release note.

Small note: on iOS the non-multiline inputs shows an enter button is that ok? (can we make this conditional?)

Image

@lunars97

lunars97 commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Tested on iOS and Android ✅

  • I think you need to add a release note.

Small note: on iOS the non-multiline inputs shows an enter button is that ok? (can we make this conditional?)

Image

Good catch! I added done type there on email textfield. I don't think it needs to have conditional...

@lunars97
lunars97 force-pushed the 4497-use-search-as-enter-key-hint-for-search branch 2 times, most recently from c0b7dca to fea6e9a Compare October 22, 2026 22:56
@bahaaTuffaha

bahaaTuffaha commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tested on iOS and Android ✅

  • I think you need to add a release note.

Small note: on iOS the non-multiline inputs shows an enter button is that ok? (can we make this conditional?)
Image

Good catch! I added done type there on email textfield. I don't think it needs to have conditional...

what about malte's forms? Lets me check...

@lunars97

lunars97 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Tested on iOS and Android ✅

  • I think you need to add a release note.

Small note: on iOS the non-multiline inputs shows an enter button is that ok? (can we make this conditional?)
Image

Good catch! I added done type there on email textfield. I don't think it needs to have conditional...

what about malte's forms? Lets me check...

I tested it, it works as expected...

@bahaaTuffaha

bahaaTuffaha commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

what about malte's forms? Lets me check...

I tested it, it works as expected...

Nice. then all good I guess 👍

@lunars97
lunars97 force-pushed the 4497-use-search-as-enter-key-hint-for-search branch from fea6e9a to 8b6fa89 Compare October 23, 2026 11:01
@bahaaTuffaha

bahaaTuffaha commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

This is what I was talking about:
Screenshot iPhone 18 Pro 23-10-2026 at 2 02 47 PM

@lunars97

lunars97 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

This is what I was talking about: Screenshot iPhone 18 Pro 23-10-2026 at 2 02 47 PM

hmm in android it looks as expected, is it only in name or in all the fields?

@bahaaTuffaha

bahaaTuffaha commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

hmm in android it looks as expected, is it only in name or in all the fields?

On android it has a fallback unlike iOS

@lunars97

lunars97 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

hmm in android it looks as expected, is it only in name or in all the fields?

On android it has a fallback unlike iOS

I will check it out 👍

@lunars97
lunars97 requested a review from bahaaTuffaha October 23, 2026 23:01
bahaaTuffaha
bahaaTuffaha reviewed Oct 26, 2026
View reviewed changes
Comment thread native/src/components/Feedback.tsx

@bahaaTuffaha bahaaTuffaha Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search feedback still return:
Image

Comment thread native/src/components/base/InputSection.tsx
contentStyle={multiline ? { textAlignVertical: 'top' } : {}}
keyboardType={keyboardType}
error={invalid}
returnKeyType='done'

@bahaaTuffaha bahaaTuffaha Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ would it be better if we simplified this into:

 returnKeyType={multiline ? 'default' : 'done'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bahaaTuffaha bahaaTuffaha bahaaTuffaha approved these changes
@steffenkleinle steffenkleinle steffenkleinle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Region selection: Highlight the search key on the keyboard

3 participants

@lunars97 @bahaaTuffaha @steffenkleinle