Skip to content

fix: fix deprecator to exactly match python 3.13 API #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 5 commits into from
Dec 10, 2025
Merged

fix: fix deprecator to exactly match python 3.13 API #366

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0728a44
update deprecator to exactly match 3.13 deprecated decorator
cadenmyers13 Nov 24, 2025
1d936d7
comment
cadenmyers13 Nov 24, 2025
af8c0b1
news
cadenmyers13 Dec 9, 2025
d3c6e87
docstring
cadenmyers13 Dec 9, 2025
3b7b13b
examples in docstring
cadenmyers13 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@cadenmyers13
cadenmyers13 committed Nov 24, 2025
commit 1d936d77fc0ccb3acea09ac9047de94f0df75132
6 changes: 0 additions & 6 deletions src/diffpy/utils/_deprecator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,18 @@ def deprecated(message, *, category=DeprecationWarning, stacklevel=1):

Matches the Python 3.13 warnings.deprecated API exactly.
"""
# If Python 3.13 implementation exists, delegate to it
if _builtin_deprecated is not None:
return _builtin_deprecated(
message, category=category, stacklevel=stacklevel
)

# Validate message type like Python 3.13 does
if not isinstance(message, str):
raise TypeError(
f"Expected an object of type str for 'message', not "
f"{type(message).__name__!r}"
)

def decorator(obj):
# Set __deprecated__ attribute (required by PEP 702)
setattr(obj, "__deprecated__", message)

# Must support functions AND classes
if callable(obj):

@functools.wraps(obj)
Expand Down