Skip to content

Load headers in loadData - #13

Closed
Sparks29032 wants to merge 2 commits into
diffpy:mainfrom
Sparks29032:new_loadData_feature
Closed

Sparks29032 wants to merge 2 commits into
diffpy:mainfrom
Sparks29032:new_loadData_feature

Conversation

@Sparks29032

@Sparks29032 Sparks29032 commented Jul 19, 2023 •

Copy link
Copy Markdown
Collaborator

First commit attempts to remove a deprecation (fixes #12). If does not work, will revert.

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is doing 2 things....the header parsing and the pkg_resources. Let's close this and put those on separate PRs.

In the mean-time, I want to take this opportunity to change the default branch from master to main which means you will have to run a couple of commands to reconnect your local.

It is a good time to do it before we start opening PRs and working on here.

@Sparks29032
Sparks29032 deleted the new_loadData_feature branch July 24, 2023 02:39
@Sparks29032
Sparks29032 restored the new_loadData_feature branch July 25, 2023 02:12
@Sparks29032
Sparks29032 deleted the new_loadData_feature branch July 25, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg_resources deprecated

2 participants