Repository navigation
skpkg: scikit-package to the latest workflow standard - #97
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 27 27
Lines 3967 3967
=======================================
Hits 3916 3916
Misses 51 51
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Oct 11, 2026
| @@ -17,11 +17,5 @@ jobs: | |||
| project: diffpy.srreal | |||
| c_extension: true | |||
| headless: false | |||
| run: | | |||
| @@ -1,5 +1,5 @@ | |||
| default_language_version: | |||
| python: python3 | |||
| python: python3.14 | |||
Contributor
There was a problem hiding this comment.
I think this should be unchanged as python3
SYMSCAE
reviewed
Oct 12, 2026
Contributor
There was a problem hiding this comment.
Please remove this file as this wasn't used.
Contributor
Author
|
OK, have removed the |
Contributor
|
LGTM. Not seeing anything obvious that breaks the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge @SYMSCAE ready to review. I'm not a C expert so need some review over whether the setup is right. Mostly automatically done by the update command, but for
scikit-package update, it creates asetup.pythat controls the extension of C code, but not sure whether we actually need this from the nanobind conversion perspective. If it does not need it, let me know and I would delete it in the next commit.