Skip to content

enh: Modernize array handling with nanobind #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 3 commits into from
Oct 11, 2026
Merged

enh: Modernize array handling with nanobind #94

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a77324b
fix: fix QuantityType slice assignment
SYMSCAE Oct 11, 2026
ded06b1
Modernize array handling with nanobind
SYMSCAE Oct 11, 2026
2355f21
[pre-commit.ci] auto fixes from pre-commit hooks
pre-commit-ci[bot] Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: fix QuantityType slice assignment
  • Loading branch information
@SYMSCAE
SYMSCAE committed Oct 11, 2026
commit a77324bb76e825b63c4c03db0e2b479738219dd8
7 changes: 5 additions & 2 deletions src/extensions/wrap_PairQuantity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,11 @@ void set_quantity_slice(QuantityType& values, nb::slice slice, nb::object items)
{
auto [first, last, step, count] = slice.compute(values.size());
// Finish conversion before editing, including when items aliases values.
QuantityType buffer;
QuantityType replacement = extractQuantityType(items, buffer);
// Convert elements as the original vector binding did, so NumPy handles
// byte order and strides instead of using extractQuantityType's raw buffer.
QuantityType replacement;
for (nb::handle item : items)
replacement.push_back(nb::cast<double>(item));

if (step == 1)
{
Expand Down