Skip to content

fix:hot-fix pdfgui functionality fix after skpkg #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 5 commits into from
Apr 3, 2026
+53 −30
Merged

fix:hot-fix pdfgui functionality fix after skpkg #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0763f01
fix:pdfgui functionality fix after skpkg
stevenhua0320 Mar 27, 2026
dfa6be6
fix: fix link fits with string input with error message pops
stevenhua0320 Mar 30, 2026
8b8ede6
chore: retrigger the workflow run after releasing pdffit2
stevenhua0320 Mar 30, 2026
293b531
chore: revert incorrect fix
stevenhua0320 Mar 30, 2026
a6c09b3
build: change headless to true to enable virtual display
stevenhua0320 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: revert incorrect fix
  • Loading branch information
@stevenhua0320
stevenhua0320 committed Mar 30, 2026
commit 293b53188ee73d627add0e39e61bacc36c178685
4 changes: 2 additions & 2 deletions news/fix-gui-functionality.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
**Added:**

* <news item>
* No News Added: fix gui functionality after skpkg

**Changed:**

Expand All @@ -16,7 +16,7 @@

**Fixed:**

* Fixed linked fits with string input
* <news item>

**Security:**

Expand Down
5 changes: 1 addition & 4 deletions src/diffpy/pdfgui/gui/parameterspanel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,7 @@ def applyCellChange(self, row, col, value):
temp = self.parameters[key].initialValue()
if temp != value:
self.parameters[key].setInitial(value)
if value is int or value is float:
self.grid_parameters.SetCellValue(row, 0, str(float(value)))
else:
self.grid_parameters.SetCellValue(row, 0, value)
self.grid_parameters.SetCellValue(row, 0, str(float(value)))
self.mainFrame.needsSave()

elif col == 1: # flag "fixed"
Expand Down
Loading