Skip to content

deprecated: Migrate changes made from srfit deprecation and change function names in pdf module #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 30 commits into from
Mar 21, 2026
Merged

deprecated: Migrate changes made from srfit deprecation and change function names in pdf module #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6da5a92
basepdfgenerator.py
cadenmyers13 Mar 18, 2026
090409e
characteristicfunctions.py
cadenmyers13 Mar 18, 2026
4118a1c
copy rest of modified srfit files here
cadenmyers13 Mar 18, 2026
67d8e7a
remove pdfparser in favor of ProfileParser
cadenmyers13 Mar 18, 2026
a0f55cd
setScatteringType --> set_scattering_type
cadenmyers13 Mar 18, 2026
f052128
getScatteringType --> get_scattering_type
cadenmyers13 Mar 18, 2026
7fe7f08
setQmax --> set_qmax
cadenmyers13 Mar 18, 2026
efae5b2
copy over test_pdf.py
cadenmyers13 Mar 18, 2026
f45e5cf
docstring improvement
cadenmyers13 Mar 18, 2026
dba8852
getQmax --> get_qmax
cadenmyers13 Mar 18, 2026
e27133a
setQmin --> set_qmin
cadenmyers13 Mar 18, 2026
4b41c42
getQmin --> get_qmin
cadenmyers13 Mar 18, 2026
fc56895
change stru to structure everywhere
cadenmyers13 Mar 18, 2026
d2dd56b
setPhase --> set_structure_from_parset
cadenmyers13 Mar 18, 2026
13abb50
spheroidalCF --> spheroidal_particle
cadenmyers13 Mar 19, 2026
f0851c3
lognormalSphericalCF --> lognormal_spherical_distribution
cadenmyers13 Mar 19, 2026
971fd7e
sheetCF --> sheet_particle
cadenmyers13 Mar 19, 2026
4c52841
shellCF --> spherical_shell
cadenmyers13 Mar 19, 2026
b742d4d
shellCF2 --> _calculate_shell_cf
cadenmyers13 Mar 19, 2026
70e8403
update parser testing
cadenmyers13 Mar 19, 2026
3c2073a
tests passing checkpoint 2
cadenmyers13 Mar 19, 2026
0f2ed66
all tests passing
cadenmyers13 Mar 19, 2026
f102f1b
rm unittest import
cadenmyers13 Mar 19, 2026
da8c24e
debyepdfpgenerator.py
cadenmyers13 Mar 19, 2026
768580b
pdfcontribution.py
cadenmyers13 Mar 19, 2026
10262a7
add method to generate a PDF from a structure
cadenmyers13 Mar 19, 2026
852ae74
break out tests into separate files
cadenmyers13 Mar 19, 2026
ed5b173
rm PDF generator functions, will put on another PR
cadenmyers13 Mar 19, 2026
3012727
news
cadenmyers13 Mar 19, 2026
688a5fa
add srreal srfit and structure to this conda.txt and pip.txt
cadenmyers13 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
setScatteringType --> set_scattering_type
  • Loading branch information
@cadenmyers13
cadenmyers13 committed Mar 18, 2026
commit a0f55cd83518c8bb324a28789ceed6f37d4cb92e
8 changes: 4 additions & 4 deletions src/diffpy/cmipdf/basepdfgenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class BasePDFGenerator(ProfileGenerator):
---------------
stype
The scattering type "X" for x-ray, "N" for neutron (see
'setScatteringType').
'set_scattering_type').
qmax
The maximum scattering vector used to generate the PDF (see
setQmax).
Expand Down Expand Up @@ -161,7 +161,7 @@ def _process_metadata(self):

stype = self.meta.get("stype")
if stype is not None:
self.setScatteringType(stype)
self.set_scattering_type(stype)

qmax = self.meta.get("qmax")
if qmax is not None:
Expand All @@ -179,7 +179,7 @@ def _process_metadata(self):

return

def setScatteringType(self, stype="X"):
def set_scattering_type(self, stype="X"):
"""Set the scattering type.

Parameters
Expand All @@ -199,7 +199,7 @@ def setScatteringType(self, stype="X"):
def getScatteringType(self):
"""Get the scattering type.

See 'setScatteringType'.
See 'set_scattering_type'.
"""
return self._calc.getRadiationType()

Expand Down
2 changes: 1 addition & 1 deletion src/diffpy/cmipdf/debyepdfgenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class DebyePDFGenerator(BasePDFGenerator):
---------------
stype
The scattering type "X" for x-ray, "N" for neutron (see
'setScatteringType').
'set_scattering_type').
qmax
The maximum scattering vector used to generate the PDF (see
setQmax).
Expand Down
6 changes: 3 additions & 3 deletions src/diffpy/cmipdf/pdfcontribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def _get_meta_value(self, kwd):
val = self.profile.meta.get(kwd)
return val

def setScatteringType(self, type="X"):
def set_scattering_type(self, type="X"):
"""Set the scattering type.

Parameters
Expand All @@ -305,13 +305,13 @@ def setScatteringType(self, type="X"):
"""
self._meta["stype"] = type
for gen in self._generators.values():
gen.setScatteringType(type)
gen.set_scattering_type(type)
return

def getScatteringType(self):
"""Get the scattering type.

See 'setScatteringType'.
See 'set_scattering_type'.
"""
return self._get_meta_value("stype")

Expand Down
2 changes: 1 addition & 1 deletion src/diffpy/cmipdf/pdfgenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class PDFGenerator(BasePDFGenerator):
---------------
stype
The scattering type "X" for x-ray, "N" for neutron (see
'setScatteringType').
'set_scattering_type').
qmax
The maximum scattering vector used to generate the PDF (see
setQmax).
Expand Down
2 changes: 1 addition & 1 deletion tests/test_pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def testGenerator(

qmax = 27.0
gen = PDFGenerator()
gen.setScatteringType("N")
gen.set_scattering_type("N")
assert "N" == gen.getScatteringType()
gen.setQmax(qmax)
assert qmax == pytest.approx(gen.getQmax())
Expand Down