Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an operator opt-out for HTTP/2 without rewriting compiled bundles. Closes #15313.
OMNIROUTE_UPSTREAM_HTTP2_ENABLEDkeeps the current enabled default; explicitfalse,0,no, oroffforces HTTP/1.1 on the shared Undici direct/proxy dispatchers and both relay agents. The proxy construction threads it through bothrequestTlsandproxyTls, merging the existing family pin. The SOCKS connector inherits the shared TLS options. Normal and fresh-socket retry paths are covered.Connection limits, keep-alive, pipelining, authentication, and certificate validation stay intact. Changing the flag requires a restart because dispatchers are cached and relay agents are created at startup. It does not control wreq or provider-specific transports, and is not a quota fix or proof that HTTP/2 caused an OOM.
The new loopback tests failed before the change with
protocol: '2.0'despite the opt-out and pass afterward withprotocol: '1.1'. They use a trusted temporary certificate, an HTTP/2 origin with HTTP/1 fallback, authenticated HTTP/HTTPS CONNECT proxies, and a SOCKS5 proxy. Coverage includes a 4 MiB POST, concurrent POSTs, relay retries, the enabled default, and rejection of an untrusted certificate.Validation on Node 24.19.0:
npm run test:vitest: 54 files, 493/493 passed.tsc --noEmit -p open-sse/tsconfig.jsonpassed.npm run check:docs-allpassed with command-local Git Bash shell/npm launchers on Windows. Existing advisory version/count drift remains.The broader
tls-proxy-context.test.tsrun has six baseline failures; I reproduced the same failures in the second worktree with unmodified transport sources and the same dependencies. Those files were not changed. Full native unit-suite coverage and a production build/deployment were not run for this PR.