Repository navigation
provide lambda for writing mesh files - #141
Conversation
remove floops writer
update version string
copy over docstring
python formatting
|
|
||
| Based on a contribution by [@simbilod](https://github.com/simbilod) `devsim.write_devices` now supports reducing the file size of data files by specifying a callback function to reduce data usage. This is through the `include_test` option. This option is a function that takes a string and returns `True` if the model should be written. It is only supported for the `tecplot` and `vtk` formats. | ||
|
|
||
| An example is provided in `testing/XXXXX.py` |
There was a problem hiding this comment.
should XXXXX be mesh2d.py ?
There was a problem hiding this comment.
thanks, I'll clean this up at the end.
There was a problem hiding this comment.
It is not immediately obvious to me how this change relates to the commit message and PR. Having a separate commit with a message explaining why this is removed could be good for documentation purposes. But we can just merge this time :)
There was a problem hiding this comment.
The format was very used. It was supposed to be compatible this FLOOPS/FLOODS simulator output for visualization in a software named Postmini
|
Yes it is better to simplify to a single flag and a single share object reused across the writers to handle this. Thanks! |
|
The stuff with MathEval were dead code that was never used. |
2 participants
Description of changes:
Instead of a regex, use an lambda to determine whether a field should be written to a Tecplot or VTK file.
Also remove floops/floods writer.
Licensing
To maintain the integrity of the project, we require contributions to be licensed under the Apache License Version 2.0. Please acknowledge this by checking the box below. By checking the box, you also acknowledge that you have the authority to license your contribution in this manner. You should also ensure that any new file you add contains "# SPDX-License-Identifier: Apache-2.0" in the header.