Skip to content

WIP Pass extra argument to actions #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lkmill wants to merge 19 commits into
base: master
Choose a base branch
from
Open

WIP Pass extra argument to actions #183

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4d862dc
Implement new action creator logic
lkmill Dec 1, 2019
7214734
Update tests to work with new action creators
lkmill Dec 1, 2019
5e05817
Update types to match new action logic
lkmill Dec 1, 2019
5f629f7
Pass update object to listeners
lkmill Dec 1, 2019
c90747d
Pass update object to devtools on action
lkmill Dec 1, 2019
9f22c9c
Differentiate between unnamed actions and direct setState calls in de…
lkmill Dec 1, 2019
3b1e5b9
Update tests to handle update argument in listeners
lkmill Dec 1, 2019
e856053
Prefer action.type over action.name
lkmill Dec 2, 2019
91ad719
Pass store.getState and store.action to action functions
lkmill Apr 5, 2020
203dc79
Split Action type into separate AsyncAction and SyncAction
lkmill Apr 5, 2020
a682ffd
Update Action and MappedAction object types
lkmill Apr 5, 2020
49c4f87
Allow null mapStateToProps
lkmill Apr 5, 2020
4dc3fde
Use correct type letter for store state
lkmill Apr 5, 2020
c246282
Rename store.action to store.dispatch
lkmill Apr 6, 2020
f388389
Move out dispatch and getState to fix this reference errors
lkmill Apr 6, 2020
f53452e
Update tests to pass new logic
lkmill Apr 6, 2020
4361a83
Print state properties that have changed in unnamed actions and setState
lkmill Apr 7, 2020
ac1f2ca
Set update to empty object if not supplied
lkmill Apr 16, 2020
04bdd86
Implement extra argument
lkmill Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests to handle update argument in listeners
  • Loading branch information
@lkmill
lkmill committed Dec 1, 2019
commit 3b1e5b9ff06e673020d596c899754586c5057890
12 changes: 7 additions & 5 deletions test/unistore.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,17 @@ describe('createStore()', () => {
let rval = store.subscribe(sub1);
expect(rval).toBeInstanceOf(Function);

store.setState({ a: 'b' });
expect(sub1).toBeCalledWith(store.getState(), action);
let update1 = { a: 'b' };
store.setState(update1);
expect(sub1).toBeCalledWith(store.getState(), action, update1);

store.subscribe(sub2);
store.setState({ c: 'd' });
let update2 = { c: 'd' };
store.setState(update2);

expect(sub1).toHaveBeenCalledTimes(2);
expect(sub1).toHaveBeenLastCalledWith(store.getState(), action);
expect(sub2).toBeCalledWith(store.getState(), action);
expect(sub1).toHaveBeenLastCalledWith(store.getState(), action, update2);
expect(sub2).toBeCalledWith(store.getState(), action, update2);
});

it('should unsubscribe', () => {
Expand Down