Repository navigation
HttpOci: Retry fetching bearer token anonymously if credentials appear expired - #515
Merged
Merged
Conversation
Christof Marti (chrmarti)
requested changes
May 9, 2023
Christof Marti (chrmarti)
left a comment
Christof Marti (chrmarti)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick response! Left a single comment.
Christof Marti (chrmarti)
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: microsoft/vscode-remote-release#8449
When trying to resolve a bearer token, we first attempt with the user credentials available to us for that service. If the returned response is 401 or 403 (ghcr appears to return 403), then we attempt one more time after clearing the
Authorizationheader.In this example, I set a GitHub PAT via
docker loginand then revoked the PAT.