Conversation
The REST API supports useDcr/dcrUrl on outbound apps but the SDK's create/update request builder dropped them, silently clearing DCR config on any update call. Add both fields, always included in the payload (unconditionally, like the Go SDK) so a false/empty value explicitly clears DCR instead of leaving it ambiguous. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
🐕 Shuni ReviewAdds Actionable comments posted: 0 Merge risk: 🟢 Low: the new trailing kwargs match the builder's argument order in both the sync and async clients. Always sending the fields fits the documented rule that an update overrides every field. 🤖 Model: Review scope: Full review Reviewed files (5)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/_outbound_application_base.py
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDcr/dcrUrlon outbound apps, but the SDK's create/update request builder dropped them — callingupdate_applicationon an app with DCR enabled silently cleared its DCR config since the SDK couldn't carry those fields.use_dcr: bool = Falseanddcr_url: str = ""tocreate_application/update_application(sync + async) and to_compose_create_update_body. Both fields are always included in the payload (unconditionally), so a false/empty value explicitly clears DCR rather than leaving it ambiguous.Test plan
test_create_application_with_dcr_success/test_update_application_with_dcr_successassertinguseDcr/dcrUrlare sent in the exact request payload._compose_create_update_bodyunit tests to expect the two new always-present fields.pytest --ignore=tests/e2e: 1106 passed.ruff checkclean on changed files.