fix: preserve reserved characters in query filters - #62
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters containing reserved URL characters are currently concatenated directly into query strings. For example,
eq,name,R&D #1becomes a different filter and introduces a fragment, while+and%20in names are decoded as spaces.Encode query keys and values with urllib.parse.urlencode, retaining repeated list parameters, omission of None values, and the existing comma-separated filter syntax. This fixes the shared helper used by managed devices, deployments, service templates, and firmware repositories.
Validation: all 515 tests pass, including two regressions that fail before the change. Pylint reports 10/10 for both changed files; git diff --check passes. No live PowerFlex appliance was used.