Skip to content

docs(agents): require a documentation check before opening a PR - #526

Merged
jamesbhobbs merged 1 commit into
mainfrom
jh/agents-docs-check
Sep 23, 2026
Merged

jamesbhobbs merged 1 commit into
mainfrom
jh/agents-docs-check

Conversation

@jamesbhobbs

@jamesbhobbs jamesbhobbs commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Adds a "Keeping Documentation in Sync" section to AGENTS.md (inherited by CLAUDE.md) so agents check whether a change makes documentation stale before opening a PR, and know where each kind of documentation lives.

Notably, docs/ in this repository is the source of truth for the product documentation published at https://deepnote.com/docs — including features built in other repositories — so that is called out explicitly.

Part of a small pass applying the same rule across the Deepnote repos.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added contributor guidance to review and update affected documentation before opening pull requests.
    • Clarified that documentation changes should be limited to directly affected pages.

Point agents at the docs that can go stale — `docs/` (published at
deepnote.com/docs), package READMEs, and the repo-level guides — so a
behavior change and its documentation land in the same pull request.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jamesbhobbs
jamesbhobbs requested a review from a team as a code owner September 21, 2026 16:06
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 866caa80-cb2b-45ef-aa42-f6bd5102f4f2

📥 Commits

Reviewing files that changed from the base of the PR and between 9083564 and de22dc2.

📒 Files selected for processing (1)
  • AGENTS.md

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

AGENTS.md now requires contributors to review affected product, package, skill, and repository workflow documentation before opening a pull request. The guidance limits documentation updates to pages directly affected by the code change.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: tkislan

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: requiring a documentation check before opening a pull request in AGENTS.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Updates Docs ✅ Passed PASS — The review-scoped diff changes only AGENTS.md and adds documentation guidance. It does not implement a product feature that requires product documentation or a roadmap update. The new section…

Warning

Some tools did not complete. Review the errors below.

🔧 LanguageTool

LanguageTool checks were skipped: reviews.tools.languagetool.enabled_only requires at least one selection in enabled_rules or enabled_categories. Select rules/categories, set enabled_only to false to use the default rules, or set enabled to false to disable LanguageTool.


Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (9083564) to head (de22dc2).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #526    +/-   ##
========================================
  Coverage   89.86%   89.86%            
========================================
  Files         207      207            
  Lines       12200    12200            
  Branches     3514     3411   -103     
========================================
  Hits        10963    10963            
  Misses       1234     1234            
  Partials        3        3            

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesbhobbs

Copy link
Copy Markdown
Contributor Author

Not prod code, admin merging

@jamesbhobbs
jamesbhobbs merged commit 2cf2a2a into main Sep 23, 2026
22 checks passed
@jamesbhobbs
jamesbhobbs deleted the jh/agents-docs-check branch September 23, 2026 09:07
jamesbhobbs added a commit that referenced this pull request Oct 1, 2026
The branch was cut before #546/#547 raised the `undici` override to 6.28.1.
The merge kept main's `undici@6.28.1` package entry alongside the
`undici: 6.28.0` snapshot reference introduced with `@ai-sdk/provider-utils`,
so `pnpm install --frozen-lockfile` failed with
ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY and took every CI job with it.

Also document the agent providers in the runtime-core README, per the
documentation check added in #526.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant