Conversation
…#217 An issue-fork branch can target a newer Drupal core than the workspace's drupal_version parameter (e.g. a "main"/12.x branch checked out into a drupal_version=11 workspace, which configures PHP 8.4). Composer then fails in generateMetapackages, poisons composer.local.lock, and all 3 retries fail identically in 1-2s each without surfacing the real cause. Read the checked-out branch's core/composer.json PHP requirement and compare it to the DDEV-configured PHP version before running composer, failing fast with a clear message instead of burning the retry loop. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drupal_version(e.g. amain/12.x branch checked out into adrupal_version=11workspace, which configures PHP 8.4) madecomposer installfail ingenerateMetapackageswithClass "Drupal" not found. That first failure poisonscomposer.local.lock, so all 3 retries then failed identically in 1-2s each, hiding the real cause.>=8.5.0, workspace was configured for PHP 8.4.drupal-core/template.tfthat, after checkout and DDEV configuration, reads the checked-out branch'score/composer.jsonPHP requirement and compares it against the DDEV-configured PHP version. On a mismatch it fails fast with a clear message (naming the required vs. configured PHP versions) instead of burning the composer retry loop.Note: this should probably not be pulled/merged until after DrupalCon Rotterdam, to avoid template churn during the conference. Opening as draft for visibility in the meantime.
Test plan
terraform fmt -recursivemake validatemake test-templates(41 tests, no regressions)jq/awkextraction against the real broken workspace's files (8.5required vs8.4configured → correctly flagged)🤖 Generated with Claude Code