experimental: fix help banner box alignment - #6906
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
The banner used U+26A0 (warning sign) plus a U+FE0F variation selector, whose terminal display width is ambiguous: Terminal.app renders it as 1 column while Ghostty renders it as 2, so the right border only lined up on the former. Switch to U+1F6A7 (construction sign), a single-codepoint emoji that is width-2 by default, widen the borders to match, and pad both inner edges symmetrically. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: a6bc2e7
Top 4 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace the
experimental --helpbanner's⚠️(U+26A0+U+FE0F) with the construction sign🚧(U+1F6A7), widen the box borders to match, and pad both inner edges symmetrically.Why
⚠️carries a variation selector and has ambiguous terminal display width — Terminal.app renders it as 1 column, Ghostty as 2 — so the box's right border only lined up in some terminals.🚧is a single-codepoint emoji that is width-2 (Emoji_Presentation=Yes) by default, so the box aligns consistently.No changelog fragment: the command lives under
experimental/and is hidden, so per the repo convention it gets no entry until it graduates.Tests
Built the CLI and ran
databricks experimental --helpin both Terminal.app and Ghostty; the box borders line up in both.This pull request and its description were written by Isaac.