Skip to content

Limit standalone Python CI to relevant changes - #6896

Open
pietern wants to merge 2 commits into
mainfrom
pieter/python-ci-relevant-changes
Open

pietern wants to merge 2 commits into
mainfrom
pieter/python-ci-relevant-changes

Conversation

@pietern

@pietern pietern commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Gate Python tests, lint, and docs on relevant changes while keeping generation checks unrestricted and making change-detection failures fail all Python jobs.

Why

Avoid unnecessary Python CI runs and transient failures on unrelated changes.

Tests

YAML formatting, actionlint, and git diff --check.

This PR was written with Codex.

@pietern
pietern requested a review from a team as a code owner October 1, 2026 09:46
@pietern
pietern requested a review from andrewnester October 1, 2026 09:46
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 412fe3e

Run: 36882109923

Env ✅​pass 🙈​skip Time
✅​ aws linux 276 15 5:36
✅​ aws windows 278 13 7:17
✅​ azure linux 275 15 6:27
✅​ azure windows 277 13 7:24
✅​ gcp linux 276 15 5:39
✅​ gcp windows 278 13 7:35
Top 6 slowest tests (at least 2 minutes):
duration env testname
7:33 gcp windows TestAccept
7:22 azure windows TestAccept
7:15 aws windows TestAccept
4:14 aws linux TestAccept
3:59 azure linux TestAccept
3:53 gcp linux TestAccept

Comment thread .github/workflows/python_push.yml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is stale, this will not always run on main now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 412fe3e. The comment now states that relevant Python jobs run on main to seed caches reused by pull request and merge queue runs.

go.mod \
go.sum \
libs/dyn/dynvar/testdata/reference_vectors.json \
python/ \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python/ \
python/ \
acceptance/bundle/python/ \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a python test that reads the test fixtures:

_ACCEPTANCE_DIR = Path(__file__).parents[3] / "acceptance" / "bundle" / "python"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add the acceptance tests directory before merging

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants