Skip to content

support $${...} escape for literal ${...} in bundle configs #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 11 commits into from
Sep 2, 2026
Merged

support $${...} escape for literal ${...} in bundle configs #6484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b92af44
Add acceptance test for $${...} escape in bundle variable references
denik Sep 2, 2026
bdcd857
Support $${...} escape for literal ${...} in bundle configs
denik Sep 2, 2026
afb9e3b
Add job_escaped_refs invariant config; include issue's exact reproducer
denik Sep 2, 2026
c66a43f
Use verbatim config from the issue in both test fixtures
denik Sep 2, 2026
f89697f
Drop redundant variables/escape validate test
denik Sep 2, 2026
cf01033
Regen invariant out.test.toml with job_escaped_refs
denik Sep 2, 2026
9f6901f
acc: document $${resources.X} escape limitation in resource_deps
denik Sep 2, 2026
2a78b25
Show depends_on from JSON plan in escaped_ref test
denik Sep 2, 2026
760199a
Unescape $${...} at payload construction instead of during resolution
denik Sep 2, 2026
4659350
Restore resource_deps/escaped_ref as a regression guard
denik Sep 2, 2026
c22ba90
Add READPLAN variant to both escape deploy tests
denik Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop redundant variables/escape validate test 
The invariant no_drift test with job_escaped_refs.yml.tmpl runs locally
and exercises the full plan+deploy path, which is the actual failing
codepath from the issue. The validate-only test adds nothing on top.

Co-authored-by: Isaac
  • Loading branch information
@denik
denik committed Sep 2, 2026
commit f89697f7e394d9147a33088ae269b14396db23a9
23 changes: 0 additions & 23 deletions acceptance/bundle/variables/escape/databricks.yml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions acceptance/bundle/variables/escape/out.test.toml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions acceptance/bundle/variables/escape/output.txt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion acceptance/bundle/variables/escape/script
View file
Open in desktop

This file was deleted.

Loading