Handle dependencies in legacy dictionary task values - #12611
Open
abhisek343 wants to merge 3 commits into
Open
abhisek343 wants to merge 3 commits into
abhisek343 wants to merge 3 commits into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files + 1 25 suites +1 7h 4m 58s ⏱️ + 7m 38s Results for commit 25b4932. ± Comparison against base commit 9dc535d. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Client.get()" currently fails to resolve dependencies referenced inside dictionary values in legacy task graphs. Lists and tuples are converted recursively, but dictionaries are not, so graph keys nested in dict values remain literal strings instead of becoming dependencies.
This change recursively converts dictionary values during legacy task conversion while keeping dictionary keys literal.
The regression test covers: