Conversation
AyoobMH
marked this pull request as ready for review
September 8, 2026 19:44
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ± 0 25 suites ±0 7h 35m 32s ⏱️ + 25m 48s Results for commit 6612aa0. ± Comparison against base commit 9dc535d. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted contribution, reviewed by @AyoobMH, who has confirmed understanding of the changes.
Array shuffle can wrap its sorting indices when a group is larger than both the input chunks and the target chunk-size limit. For example, 20-element input chunks with 257-element groups can silently return incorrect values; larger groups can instead raise the misleading unknown-chunk-size error. Include the actual output-group sizes when choosing the index dtype.
Addresses pydata/xarray#11212, reported by @joshua-gould, and extends the dtype bound introduced in #11615. The regression tests cover the uint8 boundary, uint16 overflow, both array axes, and repeated indices.
pixi run lint(not run; pinned Ruff and Black checks andgit diff --checkpassed for the changed files).