Skip to content

fix appveyor build binary only on develop branch - #4234

Merged
bahmutov merged 4 commits into
developfrom
fix-appveyor-build-script-only-on-develop
May 20, 2019
Merged

bahmutov merged 4 commits into
developfrom
fix-appveyor-build-script-only-on-develop

Conversation

@kuceb

@kuceb kuceb commented May 17, 2019 •

Copy link
Copy Markdown
Contributor

this gives us actual branch name, and not the PR merge target for

  • CI params in Appveyor in the server
  • windows build-binary script to only build the binary on develop

Comment thread packages/server/lib/util/ci_provider.js
bahmutov
bahmutov previously approved these changes May 20, 2019

@bahmutov bahmutov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@bahmutov
bahmutov merged commit b6ece46 into develop May 20, 2019
@cypress-bot

cypress-bot Bot commented May 23, 2019

Copy link
Copy Markdown
Contributor

Released in 3.3.1.

@emilyrohrbough
emilyrohrbough deleted the fix-appveyor-build-script-only-on-develop branch August 1, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants