Repository navigation
Fix mult slt mult rewrite rule - #13042
Merged
Merged
Conversation
mpreiner
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13039.
The bug appears to be in the original implementation of this rewrite rule from 13cc0e9.
This rewrite rule has a very specific shape that appears to target specific benchmarks from SMT-LIB; it is unlikely that this unsoundness would show up in the wild.
This adds two variants we were unsound on, both of which we (correctly) fail when using
--check-proofs-completeon main prior to this PR, due to failure to construct a complete proof.Co-Authored-By: Claude Opus 5 noreply@anthropic.com