Conversation
vszakats
marked this pull request as draft
October 1, 2026 11:35
This comment was marked as resolved.
This comment was marked as resolved.
vszakats
added a commit
that referenced
this pull request
Oct 1, 2026
…ernative Fixing: ``` [...] "https://ftpmirror.gnu.org/nettle/nettle-${NETTLE_VERSION}.tar.gz" [...] curl: (1) Protocol "http" disabled (in redirect) ``` Ref: https://github.com/curl/curl/actions/runs/36856289932/job/110349436255?pr=23214#step:20:33 Follow-up to 5008206 #21757 Cherry-picked from #23214 Closes #23217
vszakats
force-pushed
the
gha-localbuild-dir
branch
7 times, most recently
from
October 1, 2026 17:57
f9f26e6 to
7b3bae2
Compare
vszakats
changed the title
vszakats
marked this pull request as ready for review
October 1, 2026 18:03
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the outstanding HTTP/3 workflow issues before approval.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Moves local dependency builds under ~/pkg/ and revisions cache identifiers across Linux and HTTP/3 workflows.
Changes:
- Synchronizes dependency, cache, and configuration paths.
- Adds cache revision
1. - Updates HTTP/3 build references.
| File | Summary |
|---|---|
.github/workflows/linux.yml |
Updates Linux dependency paths and cache identifiers. |
.github/workflows/http3-linux.yml |
Updates HTTP/3 paths and caches; duplicate quiche verbosity flags and stale quiche path comments remain to be corrected. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 1, 2026
Possibly hinted by Copilot Bug: curl#23214 (review)
vszakats
added a commit
that referenced
this pull request
Oct 1, 2026
Also sync option order in CMake sibling. Possibly hinted by Copilot Bug: #23214 (review) Closes #23226
vszakats
force-pushed
the
gha-localbuild-dir
branch
2 times, most recently
from
October 1, 2026 19:30
a05abfa to
15fff50
Compare
Member
Author
Yep, that's an outlier because it's a binary download. It wouldn't need to be cached, but still useful as a pinning substitute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between http3-linux and linux workflows.
Move all local build installs under the
~/pkg/root, replacing~/inGHA/linux and and
~/<dep>/build/in GHA/http3-linux.Also:
To make it easy to bump when doing modifications like this, or just
want to make test that need rebuilding them.
-vv.(Useful to see BoringSSL build progress)
targetsubdir into the~/pkg/root. It failed because quiche headers remain inside the source tree,
~/quiche/quiche/include, and missing from the cache.Slight downside:
meaning they will cause some overhead for a while.