Conversation
bagder
approved these changes
Sep 22, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The shutdown wording inaccurately implies that every listed protocol waits for server acknowledgement.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Aligns documentation of blocking post-transfer and shutdown behavior across protocols.
Changes:
- Expands affected protocol lists.
- Documents blocking disconnect handlers and cross-references the multi interface guide.
| File | Description |
|---|---|
docs/TODO.md |
Updates known blocking operations. |
docs/libcurl/libcurl-multi.md |
Expands multi-interface blocking restrictions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aeroyorch
force-pushed
the
docs-multi-blocking-align
branch
2 times, most recently
from
September 22, 2026 15:19
64e7647 to
75a5e1e
Compare
aeroyorch
force-pushed
the
docs-multi-blocking-align
branch
from
September 28, 2026 14:14
75a5e1e to
fb5f6fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started looking into this because of blocking behaviour I hit doing SFTP
transfers async, mainly on disconnect and at the end of a transfer.
While digging I found the "More non-blocking" section in
docs/TODO.md, andnoticed that it and the BLOCKING section in libcurl-multi(3) do not say the
same thing. I took the chance to look at the other protocols as well, and the
two lists seem out of alignment.
Below a summary:
Post-transfer, through the
donehandler (multi_done(), lib/multi.c:717)getftpresponse()viaftp_done_control_reply()(lib/ftp.c:3752)imap_block_statemach(..., FALSE)(lib/imap.c:2036)smtp_block_statemach(..., FALSE)(lib/smtp.c:1747)ssh_block_statemach(..., FALSE)(lib/vssh/libssh2.c:3619)myssh_block_statemach(..., FALSE)(lib/vssh/libssh.c:2758)TODO.mdalready lists this one, but only for SFTP, SMTP and FTP.On disconnect, through the
disconnecthandler (lib/cshutdn.c:125)ftp_quit()->ftp_block_statemach()(lib/ftp.c:4311)imap_block_statemach(..., TRUE)(lib/imap.c:2214)pop3_block_statemach(..., TRUE)(lib/pop3.c:1626)smtp_block_statemach(..., TRUE)(lib/smtp.c:1922)ssh_block_statemach(..., TRUE)(lib/vssh/libssh2.c:3598, :3771)myssh_block_statemach(..., TRUE)(lib/vssh/libssh.c:2741, :2917)TODO.mddoes not mention this one at all.I came to this from the SFTP side, and traced the other protocols by reading the code, so very appreciated if reviewers more familiar with those could crosscheck that part.