Repository navigation
Fix solc_standard_json regression on Windows - #191
Merged
Merged
Conversation
…vironment variables were being overriden, making solc invocation fail.
Contributor
|
Nice catch @Xenomega, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's another regression with crytic-compile due to the change in this commit:
crytic-compile/crytic_compile/platform/solc_standard_json.py
Line 135 in b547d03
It invokes
solc --versionbut passes a blankdictfor theenv. Doing so will cause the following error on Windows:This PR instead changes the blank dictionary to
None, which will use the existingos.environ. Although disjointed behavior exists between how every compilation platform handles optionalenvvariables and the logic should likely be cleaned up as well.This was not tested on Linux/macOS, although
Noneis already used asenvfor other platform invocations and is none problematic so this should be fine.