Conversation
davidbenque
added
the
Ready to Review
2 of 13 tasks
Author
|
Resolved merge conflict. |
3 of 13 tasks
Contributor
|
Hi @davidbenque , thanks for the review & fixing the branch to staging last month @yflory , would you be able to have a second look so this could get unstuck? I assume 2026.6 is just around the corner and it'd be great to fix this so we can update the nixpkgs package :) |
Contributor
|
Hello, Sorry for the late reply but we will integrate these changes in the next release :) |
This change regenerates the lockfile to fix the missing `resolved` fields: ```shellSession rm package-lock.json & npm install --package-lock-only --ignore-scripts ``` Which causes issues while building Cryptpad in reproducible environments, for example when [updating in Nixpkgs](NixOS/nixpkgs#511890): ```shellSession warning: 313 out of 483 packages (64.8%) are missing 'resolved' URLs and will not be cached. warning: Packages without 'resolved' URLs: warning: - jwa warning: - safer-buffer warning: - methods warning: - minitask warning: - buffer-from warning: - looper warning: - @node-saml/node-saml warning: - jszip/node_modules/safe-buffer warning: - accepts warning: - gluejs/node_modules/resolve warning: ... and 303 more warning: More than 50% of packages are missing 'resolved' URLs. This may indicate an issue with the lockfile. warning: This is a known issue with some npm versions. See: npm/cli#6301 warning: Consider regenerating upstream's lockfile with: npm install --package-lock-only (sending an upstream PR is best) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change regenerates the lockfile to fix the missing
resolvedfields:rm package-lock.json & npm install --package-lock-only --ignore-scriptsWhich causes issues while building Cryptpad in reproducible environments, for example when updating in Nixpkgs: