Skip to content

Fix sed support on Windows clitest - #257

Merged
aaronliu0130 merged 1 commit into
cpplint:developfrom
aaronliu0130:win
Feb 25, 2024
Merged

aaronliu0130 merged 1 commit into
cpplint:developfrom
aaronliu0130:win

Conversation

@aaronliu0130

@aaronliu0130 aaronliu0130 commented Feb 24, 2024 •

Copy link
Copy Markdown
Member

The approach is to treat the last argument as the path name and only replace slashes in it. Since there isn't really a standardized .def spec and we currently have no need to test on files in distinct folders, this should be enough for now.

@aaronliu0130
aaronliu0130 requested a review from jayvdb February 25, 2024 15:22
@aaronliu0130
aaronliu0130 merged commit cb28426 into cpplint:develop Feb 25, 2024
@aaronliu0130 aaronliu0130 linked an issue Mar 19, 2024 that may be closed by this pull request
@aaronliu0130
aaronliu0130 deleted the win branch July 26, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Windows tests

2 participants