Skip to content

Fix: simplecpp ## fails to expand function-like macro when '(' is not adjacent #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulafy6 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: simplecpp ## fails to expand function-like macro when '(' is not adjacent #655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a328c4d
Fix: simplecpp ## fails to expand function-like macro when '(' is not…
paulafy6 Aug 18, 2026
a2f6f52
test: add regression test for ## PAR-style indirection (hashhash_func…
paulafy6 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix: simplecpp ## fails to expand function-like macro when '(' is not… 
… adjacent

When the ## operator concatenates two tokens to form a function-like macro
name (e.g. PREFIX_ ## kind → PREFIX_SCALAR), simplecpp looked for the
argument list '(...)' only at B->next. In PAR-style indirection patterns
the '(' is separated from B by a comma or a variadic parameter token:

  #define PAR(a, ...) a __VA_ARGS__
  #define PREFIX_SCALAR(T, N) T N
  #define DISPATCH(kind, ...) PAR(PREFIX_ ## kind, (__VA_ARGS__))
  DISPATCH(SCALAR, int, x)   // was: [unknownMacro] — now: int x

Because '(' was not found, expansion was aborted and the macro was
reported as unknownMacro, causing cppcheck to skip the entire translation
unit.

Fix: when B->next is not '(' and we are in the appendTokens context
(expandResult==false), walk forward on the same line skipping ',' separators
and resolving named parameter tokens via expandArg(). The first '(' found
(literally or as the head of an expanded argument) is used as lpar and
passed to appendTokens() as before. The forwardScan flag ensures
expandToken() is called on the result even when expandResult is false.

The forward scan is restricted to expandResult==false to avoid unintended
side-effects in the main expansion loop.
  • Loading branch information
@paulafy6
paulafy6 committed Aug 18, 2026
commit a328c4d289b2cd2c23cc332c2c16d259568dd3ae
57 changes: 51 additions & 6 deletions simplecpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2453,16 +2453,61 @@ namespace simplecpp {
output.deleteToken(A);
TokenList tokens(files);
tokens.push_back(new Token(strAB, tok->location));
// for function like macros, push the (...)
if (tokensB.empty() && sameline(B,B->next) && B->next->op=='(') {
const MacroMap::const_iterator it = macros.find(strAB);
if (it != macros.end() && expandedmacros.find(strAB) == expandedmacros.end() && it->second.functionLike()) {
const Token * const tok2 = appendTokens(tokens, loc, B->next, macros, expandedmacros, parametertokens);
// If strAB names a function-like macro, locate and append its argument list '(...)'
// from the remaining replacement tokens, then expand the whole call.
// 'forwardScan' is true when the argument list was consumed via the forward scan
// path below (not adjacent), so that expandToken() is called instead of
// the normal takeTokens() path even when expandResult is false.
bool forwardScan = false;
const MacroMap::const_iterator it = macros.find(strAB);
const bool isFunctionLikeMacro = (it != macros.end() && expandedmacros.find(strAB) == expandedmacros.end() && it->second.functionLike());
if (tokensB.empty() && isFunctionLikeMacro) {
// Fast path: '(' is the very next token after B on the same line.
const Token *lpar = (sameline(B, B->next) && B->next->op == '(') ? B->next : nullptr;
if (!lpar && !expandResult) {
// Forward-scan path: '(' is not immediately adjacent to B.
// This handles PAR-style indirection patterns such as:
// #define PAR(a, ...) a __VA_ARGS__
// #define DISPATCH(kind, ...) PAR(PREFIX_ ## kind, (__VA_ARGS__))
// where the '(' for PREFIX_kind belongs to the __VA_ARGS__ parameter
// and is separated from B by a comma in the replacement text.
// Only active in the appendTokens context (expandResult==false) to
// avoid unintended side-effects inside the main expansion loop.
for (const Token *scan = nextTok; sameline(B, scan); scan = scan->next) {
if (scan->op == '(') {
// Found a literal '(' after skipping separators.
lpar = scan;
forwardScan = true;
break;
}
if (scan->op == ',') {
// Argument separator — skip and keep scanning.
continue;
}
if (scan->name) {
// Named token: expand it and check whether it starts with '(...)'
// (covers the case where __VA_ARGS__ expands to a parenthesised list).
TokenList expanded(files);
if (expandArg(expanded, scan, loc, macros, expandedmacros, parametertokens) &&
expanded.cfront() && expanded.cfront()->op == '(') {
for (Token *t = expanded.front(); t; t = t->next)
t->location = loc;
tokens.takeTokens(expanded);
nextTok = scan->next;
forwardScan = true;
}
break; // stop at any name token, whether consumed or not
}
break; // any other operator — stop scan
}
}
if (lpar) {
const Token * const tok2 = appendTokens(tokens, loc, lpar, macros, expandedmacros, parametertokens);
if (tok2)
nextTok = tok2->next;
}
}
if (expandResult)
if (expandResult || forwardScan)
expandToken(output, loc, tokens.cfront(), macros, expandedmacros, parametertokens);
else
output.takeTokens(tokens);
Expand Down