Skip to content

Fix #613: support binary literals in preprocessor checks #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ludviggunne wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix #613: support binary literals in preprocessor checks #628

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0618d9e
Add tests
ludviggunne Feb 24, 2026
bda56f5
Fix #613
ludviggunne Feb 24, 2026
01bd386
run-tests.py: removed fixed `expr_usual_conversions.c` from exclusion…
firewave Jun 22, 2026
f54a1b5
simplecpp.cpp: fixed `readability-container-size-empty` clang-tidy wa…
firewave Jun 22, 2026
5855c28
update selfcheck.sh shebang
ludviggunne Jul 10, 2026
3acf836
skip suffix
ludviggunne Jul 10, 2026
5fb6ef4
update tests
ludviggunne Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add tests
  • Loading branch information
@ludviggunne
ludviggunne committed Jul 9, 2026
commit 0618d9e5bd80ccafaf52bf0bef0a024f667b2fed
47 changes: 47 additions & 0 deletions test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,6 +2346,52 @@ static void ifUndefFuncStyleMacro()
ASSERT_EQUALS("file0,1,syntax_error,failed to evaluate #if condition, undefined function-like macro invocation: A( ... )\n", toString(outputList));
}

static void testIfIntegerLiteral(const std::string &value, const std::string &literal, bool expectError)
{
const std::string code = "#define A " + value + "\n"
"#if A == " + literal + "\n"
"int x = " + literal + ";\n"
"#endif\n";

simplecpp::OutputList outputList;

std::string literalPreprocessed = literal;
if (literalPreprocessed[0] == '-')
{
literalPreprocessed = "- " + literalPreprocessed.substr(1);
}

if (expectError) {
ASSERT_EQUALS("", preprocess(code.c_str(), &outputList));
ASSERT_EQUALS("file0,2,syntax_error,failed to evaluate #if condition, invalid integer literal\n", toString(outputList));
} else {
ASSERT_EQUALS("\n\nint x = " + literalPreprocessed + " ;", preprocess(code.c_str(), &outputList));
ASSERT_EQUALS("", toString(outputList));
}
}

static void ifIntegerLiteral()
{
testIfIntegerLiteral("123", "123", false);
testIfIntegerLiteral("-123", "-123", false);

testIfIntegerLiteral("123", "0x7b", false);
testIfIntegerLiteral("-123", "-0x7b", false);

testIfIntegerLiteral("123", "0x7B", false);
testIfIntegerLiteral("-123", "-0x7B", false);

testIfIntegerLiteral("123", "0173", false);
testIfIntegerLiteral("-123", "-0173", false);

testIfIntegerLiteral("123", "0b1111011", false);
testIfIntegerLiteral("-123", "-0b1111011", false);

testIfIntegerLiteral("123", "0xGH", true);
testIfIntegerLiteral("123", "019", true);
testIfIntegerLiteral("123", "0b30", true);
}

static void location1()
{
const char *code;
Expand Down Expand Up @@ -4141,6 +4187,7 @@ static void runTests(int argc, char **argv, Input input)
TEST_CASE(ifalt); // using "and", "or", etc
TEST_CASE(ifexpr);
TEST_CASE(ifUndefFuncStyleMacro);
TEST_CASE(ifIntegerLiteral);

TEST_CASE(location1);
TEST_CASE(location2);
Expand Down