Skip to content

added constness_ptr as pointer wrapper to ensure actual method constness #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
firewave wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

added constness_ptr as pointer wrapper to ensure actual method constness #548

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1c116
added `constness_ptr` as pointer wrapper to ensure actual method cons…
firewave Sep 24, 2025
2e28fbd
adjusted suppressions for `misc-const-correctness` clang-tidy warning
firewave Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
adjusted suppressions for misc-const-correctness clang-tidy warning
  • Loading branch information
@firewave
firewave committed Jun 5, 2026
commit 2e28fbd6b447c706424bb5d53e8af4e4d5be7acc
3 changes: 1 addition & 2 deletions simplecpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ void simplecpp::TokenList::clear()
{
backToken = nullptr;
while (frontToken) {
// NOLINTNEXTLINE(misc-const-correctness) - FP
Token * const next = frontToken->next;
delete SIMPLECPP_PROPAGATE_CONST_GET(frontToken);
frontToken = next;
Expand Down Expand Up @@ -1384,7 +1385,6 @@ void simplecpp::TokenList::constFoldLogicalOp(Token *tok)
void simplecpp::TokenList::constFoldQuestionOp(Token *&tok1)
{
bool gotoTok1 = false;
// NOLINTNEXTLINE(misc-const-correctness) - technically correct but used to access non-const data
for (Token *tok = tok1; tok && tok->op != ')'; tok = gotoTok1 ? tok1 : SIMPLECPP_PROPAGATE_CONST_GET(tok->next)) {
gotoTok1 = false;
if (tok->str() != "?")
Expand Down Expand Up @@ -2022,7 +2022,6 @@ namespace simplecpp {
}
}

// NOLINTNEXTLINE(misc-const-correctness) - technically correct but used to access non-const data
Token * const output_end_1 = output.back();

const Token *valueToken2;
Expand Down
Loading