Skip to content

Fix #15077 FP uninitvar for array of std::vector #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix #15077 FP uninitvar for array of std::vector #8908

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87eac7a
Update testuninitvar.cpp
chrchr-github Oct 1, 2026
4272487
Update valueflow.cpp
chrchr-github Oct 1, 2026
4f82e10
Update valueflow.cpp [skip ci]
chrchr-github Oct 1, 2026
ad69146
Update checkbufferoverrun.cpp [skip ci]
chrchr-github Oct 1, 2026
d859d3c
Update checkclass.cpp [skip ci]
chrchr-github Oct 1, 2026
95caefb
Update checksizeof.cpp [skip ci]
chrchr-github Oct 1, 2026
52e78c9
Merge branch 'cppcheck-opensource:main' into chr_15077
chrchr-github Oct 1, 2026
b178584
Update checkbufferoverrun.cpp
chrchr-github Oct 1, 2026
27c4120
Update checkclass.cpp
chrchr-github Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5990,7 +5990,7 @@ static bool needsInitialization(const Variable* var)
return true;
if (var->valueType()->type == ValueType::Type::ITERATOR)
return true;
if (var->isStlType() && var->isArray()) {
if (var->isArray() && var->getTypeName() == "std::array") {
Comment thread
chrchr-github marked this conversation as resolved.
Outdated
if (const Token* ctt = var->valueType()->containerTypeToken) {
if (ctt->isStandardType())
return true;
Expand Down
6 changes: 6 additions & 0 deletions test/testuninitvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6788,6 +6788,12 @@ class TestUninitVar : public TestFixture {
" return a[0];\n"
"}\n");
ASSERT_EQUALS("", errout_str());

valueFlowUninit("std::vector<int> f() {\n" // #15077
" const std::vector<int> a[1];\n"
" return a[0];\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value
Expand Down
Loading