Skip to content

Make copy-constructible classes copyable #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfultz2 wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Make copy-constructible classes copyable #8705

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
266b2ae
Make copy-constructible classes copyable
Jul 7, 2026
91b5418
Update other classes
Jul 7, 2026
e90f2a4
Fix the gui warnings
Jul 7, 2026
35240f5
Again
Jul 7, 2026
3b5658f
Fix the suppression
Jul 7, 2026
98d309e
Fix cppcheck warnings
Jul 8, 2026
255eebc
Merge
Jul 8, 2026
ce1b3cd
Bump the line number
Jul 8, 2026
cae79c4
Add const
Jul 10, 2026
071bed2
Fix the suppression
Jul 10, 2026
02e34a1
Add const
Jul 12, 2026
2dc602b
Revert suppression
Jul 13, 2026
0c1324c
Merge branch 'main' into complete-copyable-types
Jul 13, 2026
ac110fd
Merge
Jul 19, 2026
4eaa9b2
Switch to RefThunk
pfultz2 Jul 23, 2026
642026b
Add missing header
pfultz2 Jul 23, 2026
2a38c3f
Merge branch 'main' into complete-copyable-types
pfultz2 Jul 29, 2026
061b321
Remove suppression
pfultz2 Jul 30, 2026
598158d
Merge branch 'complete-copyable-types' of github.com:pfultz2/cppcheck…
pfultz2 Jul 30, 2026
e38dfa5
Merge branch 'main' into complete-copyable-types
pfultz2 Jul 31, 2026
6f1588e
Merge
pfultz2 Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the suppression
  • Loading branch information
Your Name
Your Name committed Jul 10, 2026
commit 071bed2a4f4a964eaf731f215e57f312844e085b
1 change: 0 additions & 1 deletion lib/symboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@
} while (unknowns && retry < 100);

// this shouldn't happen so output a debug warning
if (retry == 100 && mSettings->debugwarnings) {
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
for (const Scope& scope : scopeList) {
if (scope.isClassOrStruct() && scope.definedType->needInitialization == Type::NeedInitialization::Unknown)
debugMessage(scope.classDef, "debug", "SymbolDatabase couldn't resolve all user defined types.");
Expand Down Expand Up @@ -1835,7 +1835,6 @@
}
}

// cppcheck-suppress functionConst - has side effects
void SymbolDatabase::setArrayDimensionsUsingValueFlow()
{
// set all unknown array dimensions
Expand Down Expand Up @@ -4747,7 +4746,7 @@
typeTok = typeTok->next();
if (Token::Match(typeTok, ",|)")) { // #8333
scope->symdb->mTokenizer->syntaxError(typeTok);
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
}
if (Token::Match(typeTok, "%type% <") && Token::Match(typeTok->linkAt(1), "> :: %type%"))
typeTok = typeTok->linkAt(1)->tokAt(2);
// skip over qualification
Expand All @@ -4766,7 +4765,7 @@

if (hasBody())
scope->symdb->debugMessage(nameTok, "varid0", "Function::addArguments found argument \'" + nameTok->str() + "\' with varid 0.");
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
} else
endTok = typeTok;
} else
endTok = tok->previous();
Expand Down Expand Up @@ -5041,7 +5040,7 @@
// C4267 VC++ warning instead of several dozens lines
const int varIndex = varlist.size();
varlist.emplace_back(token_, start_, end_, varIndex, access_, type_, scope_, scope_->symdb->mSettings);
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
}

// Get variable list..
void Scope::getVariableList()
Expand Down Expand Up @@ -7290,7 +7289,7 @@

// c++17 auto type deduction of braced init list
if (parent->isCpp() && mSettings->standards.cpp >= Standards::CPP17 && vt2 && Token::Match(parent->tokAt(-2), "auto %var% {")) {
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Token *autoTok = parent->tokAt(-2);
setValueType(autoTok, *vt2);
setAutoTokenProperties(autoTok);
if (parent->previous()->variable())
Expand Down
Loading