Skip to content

Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021)) #8654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 13 commits into from
Jun 20, 2026
Merged

Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021)) #8654

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eff100e
Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in…
danmar Jun 16, 2026
b17eebc
format
danmar Jun 16, 2026
839a224
cleanup
danmar Jun 16, 2026
e78bea0
rely on gcc version
danmar Jun 16, 2026
f7d148b
cleanup
danmar Jun 16, 2026
c4de347
remove redundant semicolon
danmar Jun 16, 2026
7916620
clang-tidy
danmar Jun 16, 2026
679ada0
rename
danmar Jun 17, 2026
98eff04
test
danmar Jun 17, 2026
8542efe
comment
danmar Jun 17, 2026
dff55ca
review
danmar Jun 19, 2026
9216c9f
8
danmar Jun 19, 2026
b23b81d
skip test
dmcppcheck Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@danmar
danmar committed Jun 19, 2026
commit 679ada0fe7c18e9da5c1b37250fad96eb418691c
4 changes: 2 additions & 2 deletions lib/settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ Settings::~Settings() = default;
Settings::Settings(const Settings&) = default;
Settings & Settings::operator=(const Settings &) = default;

Settings::Settings(Settings&&) NOEXCEPT = default;
Settings & Settings::operator=(Settings &&) NOEXCEPT = default;
Settings::Settings(Settings&&) CPPCHECK_NOEXCEPT = default;
Settings & Settings::operator=(Settings &&) CPPCHECK_NOEXCEPT = default;

std::string Settings::loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug)
{
Expand Down
8 changes: 4 additions & 4 deletions lib/settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ class SimpleEnableGroup {
// seen on:
// oraclelinux:8, g++-8.5
// ubuntu:20.04, g++-9.4.0
#define NOEXCEPT
#define CPPCHECK_NOEXCEPT
#else
#define NOEXCEPT noexcept
#define CPPCHECK_NOEXCEPT noexcept
#endif
Comment thread
danmar marked this conversation as resolved.


Expand All @@ -125,8 +125,8 @@ class CPPCHECKLIB WARN_UNUSED Settings {
Settings(const Settings&);
Settings& operator=(const Settings&);

Settings(Settings&&) NOEXCEPT;
Settings& operator=(Settings&&) NOEXCEPT;
Settings(Settings&&) CPPCHECK_NOEXCEPT;
Comment thread
danmar marked this conversation as resolved.
Dismissed
Comment thread
danmar marked this conversation as resolved.
Dismissed
Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT;
Comment thread
danmar marked this conversation as resolved.
Dismissed
Comment thread
danmar marked this conversation as resolved.
Dismissed

static std::string loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug = false);

Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Expand Down