Skip to content

fixed #14331 - suppressions with line number not reported as unmatched #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
firewave wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fixed #14331 - suppressions with line number not reported as unmatched #8035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028ebec
fixed #14331 - suppressions with line number not reported as unmatched
firewave Dec 15, 2025
2ee21d7
mitigated `unmatchedSuppression` warnings in cfg tests [skip ci]
firewave Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mitigated unmatchedSuppression warnings in cfg tests [skip ci]
  • Loading branch information
@firewave
firewave committed Dec 29, 2025
commit 2ee21d7e0f289f904f85bb8f2ff3a30e94b889b9
4 changes: 2 additions & 2 deletions test/cfg/std.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@
#if __cplusplus <= 201402L
void unreachableCode_std_unexpected(int &x)
{
// cppcheck-suppress unexpectedCalled
// TODO: cppcheck-suppress unexpectedCalled
std::unexpected();
// cppcheck-suppress unreachableCode
// TODO: cppcheck-suppress unreachableCode
x=42;
}
#endif
Expand Down
26 changes: 13 additions & 13 deletions test/cfg/wxwidgets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,36 +1203,36 @@ void deprecatedFunctions([[maybe_unused]] wxApp &a,
// cppcheck-suppress ShowPopupCalled
comboCtrl.ShowPopup();
#else
// cppcheck-suppress InsertCalled
// TODO: cppcheck-suppress InsertCalled
wxArtProvider::Insert(artProvider);

// cppcheck-suppress GetTextIndentCalled
// cppcheck-suppress ignoredReturnValue
// TODO: cppcheck-suppress GetTextIndentCalled
// TODO: cppcheck-suppress ignoredReturnValue
comboCtrl.GetTextIndent();

// cppcheck-suppress HidePopupCalled
// TODO: cppcheck-suppress HidePopupCalled
comboCtrl.HidePopup(true);
// cppcheck-suppress HidePopupCalled
// TODO: cppcheck-suppress HidePopupCalled
comboCtrl.HidePopup(false);
// cppcheck-suppress HidePopupCalled
// TODO: cppcheck-suppress HidePopupCalled
comboCtrl.HidePopup(/*default=false*/);

// cppcheck-suppress SetTextIndentCalled
// TODO: cppcheck-suppress SetTextIndentCalled
comboCtrl.SetTextIndent(0);

#if wxUSE_DEBUG_CONTEXT==1
// cppcheck-suppress GetLevelCalled
// cppcheck-suppress ignoredReturnValue
// TODO: cppcheck-suppress GetLevelCalled
// TODO: cppcheck-suppress ignoredReturnValue
wxDebugContext::GetLevel();
// cppcheck-suppress SetLevelCalled
// TODO: cppcheck-suppress SetLevelCalled
wxDebugContext::SetLevel(42);
#endif

// cppcheck-suppress wxDos2UnixFilenameCalled
// TODO: cppcheck-suppress wxDos2UnixFilenameCalled
wxDos2UnixFilename(path);

// cppcheck-suppress wxFileNameFromPathCalled
// cppcheck-suppress ignoredReturnValue
// TODO: cppcheck-suppress wxFileNameFromPathCalled
// TODO: cppcheck-suppress ignoredReturnValue
wxFileNameFromPath(wxT_2("../test.c"));
#endif

Expand Down