Skip to content

[ranges] Improve examples - #5791

Merged
tkoeppe merged 4 commits into
cplusplus:mainfrom
hewillk:main-example
Aug 25, 2022
Merged

tkoeppe merged 4 commits into
cplusplus:mainfrom
hewillk:main-example

Conversation

@hewillk

@hewillk hewillk commented Aug 24, 2022

Copy link
Copy Markdown
Contributor
  1. Use views::istream instead of ranges::istream_view (consistent with [ranges] Use views::meow in examples instead of meow_view #4659).
  2. Remove unnecessary std:: qualification.

@hewillk

hewillk commented Aug 24, 2022

Copy link
Copy Markdown
Contributor Author

Hmm, how do I make these comments align?

@JohelEGP JohelEGP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing std:: removes 5 characters. Add 1 space so the comment is aligned to a multiple of 4.

Comment thread source/ranges.tex Outdated
Comment thread source/ranges.tex Outdated
Comment thread source/ranges.tex Outdated
hewillk and others added 3 commits August 25, 2022 01:34
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-authored-by: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@hewillk

hewillk commented Aug 24, 2022

Copy link
Copy Markdown
Contributor Author

You are my lifesaver, thanks.

@jensmaurer jensmaurer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tkoeppe
tkoeppe requested a review from jwakely August 25, 2022 01:25
@tkoeppe
tkoeppe merged commit 426ce8a into cplusplus:main Aug 25, 2022
@hewillk
hewillk deleted the main-example branch August 26, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants