Repository navigation
[diff.mods.to.declarations] Also mention 'byte' and 'to_integer. - #4145
Merged
Merged
Conversation
jwakely
requested changes
Sep 6, 2020
Member
There was a problem hiding this comment.
NACK. I think this is a normative change, because currently <stddef.h> is required to declare ::nullptr_t. That's how libstdc++ and libc++ interpret it (and MS STL too as far as I can tell).
C.6.3 [diffs.mods.to.declarations] is informative (not normative), and my interpretation is that it's saying "The C++ version of this header adds nullptr_t, which isn't in the C version of this header". It's not saying that <cstddef> declares it and C++'s <stddef.h> doesn't.
Contributor
Author
|
You're right. Should we create an issue for this then? (I still think this is a desirable change, but it is indeed normative.) I will replace the wording changes here with those for [diffs.mods.to.declarations]. |
These names, as well as operators for std::byte, are part of <cstddef>.
Contributor
Author
|
@jwakely: PTAL. |
tkoeppe
changed the title
jwakely
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These names, as well as operators for std::byte, are part of .
Fixes #4144.