Conversation
full diff: microsoft/go-winio@ad3df93...7e8af9b Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
LX symlink identity is lost during containerd’s Windows archive export/import round trip.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the vendored, unreleased go-winio snapshot for Windows compatibility and reliability.
Changes:
- Adds LX symlink and sparse-file handling.
- Fixes named-pipe listener shutdown races.
- Modernizes Go 1.26 code generation and lint configuration.
| File | Description |
|---|---|
go.mod |
Updates go-winio revision. |
go.sum |
Updates dependency checksums. |
vendor/modules.txt |
Records vendored module version. |
vendor/github.com/Microsoft/go-winio/reparse.go |
Adds LX symlink support. |
vendor/github.com/Microsoft/go-winio/pipe.go |
Fixes listener shutdown races. |
vendor/github.com/Microsoft/go-winio/file.go |
Refactors EOF handling. |
vendor/github.com/Microsoft/go-winio/backup.go |
Updates lint directive. |
vendor/github.com/Microsoft/go-winio/backuptar/tar.go |
Handles sparse backup streams. |
vendor/github.com/Microsoft/go-winio/backuptar/strconv.go |
Uses strings.Cut. |
vendor/github.com/Microsoft/go-winio/internal/fs/fs.go |
Formats TODO comment. |
vendor/github.com/Microsoft/go-winio/internal/stringbuffer/wstring.go |
Uses any. |
vendor/github.com/Microsoft/go-winio/pkg/bindfilter/bind_filter.go |
Modernizes iteration and lint directives. |
vendor/github.com/Microsoft/go-winio/pkg/etw/eventdescriptor.go |
Updates generation and lint directives. |
vendor/github.com/Microsoft/go-winio/pkg/etw/eventmetadata.go |
Removes obsolete lint directives. |
vendor/github.com/Microsoft/go-winio/pkg/etw/fieldopt.go |
Modernizes types and reflection usage. |
vendor/github.com/Microsoft/go-winio/pkg/etw/level_string.go |
Updates generated string conversion. |
vendor/github.com/Microsoft/go-winio/pkg/etw/opcode_string.go |
Updates generated string conversion. |
vendor/github.com/Microsoft/go-winio/pkg/etw/provider.go |
Removes obsolete lint directive. |
vendor/github.com/Microsoft/go-winio/pkg/etw/providerglobal.go |
Formats TODO comment. |
vendor/github.com/Microsoft/go-winio/pkg/etwlogrus/hook.go |
Uses slices.Sort. |
vendor/github.com/Microsoft/go-winio/pkg/guid/guid.go |
Uses Go tool directives. |
vendor/github.com/Microsoft/go-winio/pkg/guid/variant_string.go |
Updates generated string conversion. |
vendor/github.com/Microsoft/go-winio/.golangci.yml |
Migrates lint configuration to v2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing the latest changes; no tagged yet
full diff: microsoft/go-winio@ad3df93...7e8af9b