This repository was archived by the owner on Sep 19, 2025. It is now read-only.
Repository navigation
Don't require Numba to run - #14
Merged
Merged
Conversation
gmarkall
requested review from
bdice,
jakirkham and
prashantkhoje
as code owners
September 1, 2022 15:58
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
bdice
approved these changes
Sep 1, 2022
jakirkham
approved these changes
Sep 1, 2022
Member
|
Should we hot-fix past versions to include this change? |
Contributor
Author
|
I'd imagine it's not worth it to patch old versions, as I don't expect people are sticking with older versions. |
Member
|
Ok. We can always follow up later if needed |
Member
|
Thanks Graham! Also thanks Bradley for the review 🙏 |
Contributor
Author
|
Many thanks for the reviews and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Having Numba in the
runsection of the recipe forces Numba to be installed with ptxcompiler. Although ptxcompiler can patch Numba to use it, Numba isn't required for ptxcompiler to be used itself. Additionally, having ptxcompiler depend on Numba makes it hard to use ptxcompiler from Numba (e.g. for numba/numba#8180).This PR moves it to
run_constrained, so that its installation is not required, but if it is present then only versions that can be correctly patched to use ptxcompiler are allowed.