feat: warn when agent startup scripts fail or time out - #1129
Merged
Merged
Conversation
EhabY
force-pushed
the
feat/startup-script-failure-warning
branch
2 times, most recently
from
September 29, 2026 16:44
c4c4129 to
42583f8
Compare
Show a non-modal warning when the connected agent reaches start_error or start_timeout, whether before or after the connection. The warning names the failed scripts and their exit codes when the server reports them. Show Logs opens the agent logs in a terminal, and Open in Dashboard opens the workspace page. Closes #1125
EhabY
force-pushed
the
feat/startup-script-failure-warning
branch
from
September 30, 2026 12:51
42583f8 to
e17ed12
Compare
code-asher
approved these changes
Sep 30, 2026
Member
|
Ah actually did have one more suggestion, it seems to only notify you if it is starting while you connect. If you connect to an already-running workspace I saw no notification, but maybe we want one in that case as well? |
List every failed or timed-out startup script, falling back to the agent lifecycle state for servers without per-script statuses. Ignore scripts that only left pipes open, and open one log terminal per failed script.
EhabY
force-pushed
the
feat/startup-script-failure-warning
branch
from
October 1, 2026 13:43
3e83127 to
ee41036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1125.
When the connected agent reaches
start_errororstart_timeout, the extension shows a non-modal warning. Before this change, it wrote only a line to the output channel. The connection still succeeds.WorkspaceMonitorchecks the connected agent on every workspace update after setup. This also catches non-blocking scripts that fail after the connection is up, which the state machine never sees.coder.disableNotifications, like the monitor's other notifications.