fix(coderd): validate GCP instance token audience - #29765
Merged
Merged
Conversation
dylanhuff-at-coder
marked this pull request as ready for review
September 23, 2026 18:32
Emyrk
approved these changes
Sep 23, 2026
dylanhuff-at-coder
added
backport/v2.34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google instance identity authentication accepted tokens issued for any audience. A Google-signed token for a registered VM but intended for another service could therefore be exchanged for a Coder agent token.
Require
aud=coderbefore the exchange. The standard GCP agent already requests this audience. Custom clients requesting another audience will receive 401 and need to update. Add coverage for foreign-audience rejection and the returned agent token.Refs https://linear.app/codercom/issue/PLAT-655/fixcoderdworkspaceresourceauth-validate-audience-on-gcp-instance