Skip to content

chore: backport known models catalog and AI price book to 2.37 (#28887, #28909, #28939, #28955, #29170, #29218, #29226, #29471, #29585) - #29588

Merged
ibetitsmike merged 4 commits into
release/2.37from
mike/backport-known-models-2.37
Sep 18, 2026
Merged

ibetitsmike merged 4 commits into
release/2.37from
mike/backport-known-models-2.37

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Backport of the known models catalog and AI Gateway price book updates that landed on main since the August 27 refresh (#28720 was the last one on this branch), so 2.37 suggests the current models in /agents settings and prices them correctly in AI Bridge.

Source PRs: #28887 (Claude Fable 5.1, Opus 5, Gemini 3.7 Flash, GLM 5.3), #28909 (Gemini 3.8 Flash), #28939 and #29471 (price book refreshes), #28955 (GPT-6 Astra), #29170 (gpt-6-astra and qwen3.8-max upstream fixes), #29218 (OpenAI Daybreak alias pricing), #29226 (Copilot utility models at zero), #29585 (DeepSeek V4.1 Flash, Claude Mythos 5.1, Gemini Pro and Lite tiers, cross-provider gaps).

Commits:

  1. feat(coderd/x/chatd): the chatd portion of feat: add GPT-6 Astra to the known models catalog, price book, and chatd #28955, applied as-is. GPT-6 Astra's function calling is Responses-only and the pinned SDK predates it, so UsesResponsesAPI defaults it to Responses, and reasoning effort none/minimal clamp to low. Without this the catalog would suggest a model that fails in chat on 2.37.
  2. chore: curation.json and overrides.jq brought to their exact main state, then prices.json and knownModelsGenerated.json regenerated on this branch with make gen/aibridge-prices. The catalog stays at its 2.37 path under ChatModelAdminPanel/knownModels; the modules/aiModels move (refactor: move shared AI model UI into modules/aiModels #29040) is not backported, which is why the generated artifacts are regenerated rather than cherry-picked. The Anthropic thinking-mode test pin gains the same three entries as on main.
  3. docs(coderd/x/chatd): restores ARCHITECTURE.md to its 2.37 state; the TODO placeholders from feat: add GPT-6 Astra to the known models catalog, price book, and chatd #28955 were later replaced on main and do not belong in a backport.
  4. fix: omits gpt-6-astra from the azure curation and regenerated catalog entry. The 2.37 fantasy pin predates Astra and the Azure provider has no hook to force Responses, so an Azure Astra config would speak Chat Completions while Astra's function calling is Responses-only. main only added the Azure entry (chore: add DeepSeek V4.1 Flash and other missed models to the known models catalog #29585) after bumping fantasy (feat: add openai_config.reasoning_model override and bump fantasy #29230), which this backport does not carry. TestCuratedAstraUsesResponses guards the curation against reintroducing it while the pin is old.

Parity check against main: overrides identical; curation differs only by the omitted Azure Astra entry; the regenerated catalog and price book otherwise differ from main only by live models.dev drift on one OpenRouter DeepSeek price (models.dev is fetched at generation time, same as the weekly refresh).

Validation on this branch: go test ./scripts/aibridgepricesgen/... ./coderd/aibridge/prices/... ./coderd/x/chatd/chatopenai/... ./coderd/x/chatd/chatprovider/... and pnpm test src/pages/AgentsPage/components/ChatModelAdminPanel/knownModels/ (52 tests) pass; pre-commit hook passed on every commit.

Review record: Codex review on 7939e2a raised one P1 (Azure Astra transport). Confirmed by execution (TransportFor(azure, gpt-6-astra) resolves to Chat Completions on the 2.37 pin; the guard test is red on the old curation and green after) and fixed in commit 4. Codex review on fd0e070 raised two P1s asking to re-add the ARCHITECTURE.md TODO placeholders; declined per the author's direction (main already carries the human-written prose at ARCHITECTURE.md L910 and L916), replied and resolved. Re-review on fd0e070: Codex OK ("Didn't find any major issues", reviewed commit fd0e070427), zero unresolved threads, all 29 check runs green.

Xum opened this PR on behalf of @ibetitsmike.

…amp its reasoning effort

Backport of the chatd portion of #28955 (9cd66d3). GPT-6 Astra's
function calling is Responses-only and the pinned SDK predates the
model, so UsesResponsesAPI defaults it to Responses; it also rejects
reasoning effort none and lists no minimal, so both clamp to low.

(cherry picked from commit 9cd66d3, chatd files only)
…/2.37

Bring scripts/aibridgepricesgen/curation.json and overrides.jq to their
main state and regenerate prices.json and knownModelsGenerated.json with
make gen/aibridge-prices on this branch. This carries the model and
price changes from #28887, #28909, #28939, #28955, #29170, #29218,
#29226, #29471 and #29585 without cherry-picking the regenerated
artifacts across the modules/aiModels move (#29040), which is not
backported. The Anthropic thinking-mode pin gains the same entries as
on main.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T21:28:13.351896Z fd0e070 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @ibetitsmike!

This PR is targeting the release/2.37 release branch, but its title does not start with fix: or fix(scope):.

Only bug fixes should be cherry-picked to release branches. If this is a bug fix, please update the PR title to match the conventional commit format:

fix: description of the bug fix
fix(scope): description of the bug fix

If this is not a bug fix, it likely should not target a release branch.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7939e2a76e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/aibridgepricesgen/curation.json Outdated
…TURE.md

They were placeholders for the human author of #28955 and main has since replaced them with real prose; the backport should not carry them into the release branch.
The fantasy pin on release/2.37 predates gpt-6-astra, and the Azure
provider exposes no hook to force Responses, so an Azure Astra model
config would speak Chat Completions while Astra's function calling is
Responses-only. main added the Azure entry after bumping fantasy
(#29230), which the backport does not carry.

TestCuratedAstraUsesResponses guards the curation against reintroducing
an Astra entry whose resolved transport is not Responses.
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd0e070427

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread coderd/x/chatd/chatopenai/transport.go
Comment thread coderd/x/chatd/chatprovider/reasoningeffort.go
@ibetitsmike

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: fd0e070427

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibetitsmike
ibetitsmike merged commit c418d8b into release/2.37 Sep 18, 2026
43 checks passed
@ibetitsmike
ibetitsmike deleted the mike/backport-known-models-2.37 branch September 18, 2026 21:32
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants