fix(coderd/x/chatd/chatloop): tell the model to gather context before retrying an exclusive tool - #29281
Merged
Conversation
… retrying an exclusive tool
ibetitsmike
marked this pull request as ready for review
September 14, 2026 18:03
ibetitsmike
enabled auto-merge (squash)
September 14, 2026 18:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ThomasK33
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the model batches
advisor(an exclusive tool) with other tool calls, every call in the batch is rejected and theadvisorresult only says to retry withadvisoralone. That nudges the model toward re-callingadvisorimmediately, even when the sibling calls were there to gather context for it.Extend the message so the model is told to run the other tools first when it still needs their output, then retry with only the exclusive tool call.
Generated by Coder Agents on behalf of @ibetitsmike.