Skip to content

feat(site): migrate agent chat scrolling #28130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielleMaywood merged 23 commits into from
Aug 14, 2026
Merged

feat(site): migrate agent chat scrolling #28130

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
49445cc
feat(site): migrate agent chat scrolling
DanielleMaywood Aug 13, 2026
8c4b929
fix(site): keep chat history paging stable across filtered pages and …
DanielleMaywood Aug 13, 2026
8d0badb
fix(site): stabilize merged read_file row keys and derive visible row…
DanielleMaywood Aug 13, 2026
1663956
fix(site): key singleton read_file rows as groups and gate paging on …
DanielleMaywood Aug 13, 2026
ce8f668
docs(site): describe the merged read_file row key correctly
DanielleMaywood Aug 13, 2026
6e78691
fix(site): render the terminal chat failure as a transcript row
DanielleMaywood Aug 13, 2026
17e99c0
docs(site): document the merged read_file key append tradeoff
DanielleMaywood Aug 13, 2026
0d030d3
fix(site): return to the live edge on submit and stabilize the live r…
DanielleMaywood Aug 13, 2026
2d716ea
fix(site): hoist the scroller provider and scroll to the live edge on…
DanielleMaywood Aug 13, 2026
e6971cc
fix(site): key the scroller provider by chat and scroll after compact…
DanielleMaywood Aug 13, 2026
2cd3df4
fix(site): scroll to the live edge only after a history edit succeeds
DanielleMaywood Aug 13, 2026
be3c297
fix(site): suppress the scroll anchor for turns active at first render
DanielleMaywood Aug 13, 2026
c1cad2a
fix(site): capture the initial active-turn anchor at mount
DanielleMaywood Aug 13, 2026
37c90a6
fix(site): capture the initial active-turn anchor from REST data
DanielleMaywood Aug 13, 2026
e779620
fix(site): capture the initial active anchor only after the initial q…
DanielleMaywood Aug 13, 2026
8fe5e11
fix(site): capture the initial active anchor in the gated subtree
DanielleMaywood Aug 13, 2026
c8a990c
fix(site): suppress the initial active turn's anchor by message id th…
DanielleMaywood Aug 14, 2026
3eb26d7
fix(site): suppress the initial anchor for interrupting chats too
DanielleMaywood Aug 14, 2026
35a0a3f
fix(site): gate history paging on transcript rows, not visible DOM rows
DanielleMaywood Aug 14, 2026
bc6dfb7
fix(site): hold history paging until fetched messages hydrate into th…
DanielleMaywood Aug 14, 2026
e523d37
fix(site): keep the history loader tied to real fetches during hydration
DanielleMaywood Aug 14, 2026
747223f
fix(site): wait one frame before paging so fresh rows can settle
DanielleMaywood Aug 14, 2026
e823acd
fix(site): compare hydrated chat messages by content, not identity
DanielleMaywood Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(site): describe the merged read_file row key correctly
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Aug 13, 2026
commit ce8f668432351edc1498030d11351b7480cbe204
6 changes: 3 additions & 3 deletions site/src/pages/AgentsPage/components/ChatConversation/timelineRows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ const assistantSlotKey = (turnKey: string, slot: number): string =>

/**
* Durable rows keep their server IDs so prepending history never changes an
* existing Item's identity. Merged read_file groups key off the visible row
* before them for the same reason. The live assistant uses a turn-local slot
* until its durable message arrives.
* existing Item's identity. Merged read_file groups key off their newest
* member, which pagination never changes. The live assistant uses a
* turn-local slot until its durable message arrives.
*/
export const assignTimelineRows = (
displayMessages: readonly ParsedMessageEntry[],
Expand Down
Loading