Note [CRF-34] const buildQuery = buildChatSearchQuery; is a single-use alias, and its comment narrates the deleted parser. (Gon P2, Nami Nit, Meruem Nit, Netero Note)

Two names for one function in one file; the reader traces the alias to learn nothing. The comment's "without parsing it again" refers to normalizeChatSearchInput, which this PR removed; a fresh reader has no antecedent for "again." Call buildChatSearchQuery directly at line 163 and delete lines 125-127.

Same class, two more new comments in this commit restate what the code already shows: ChatSearchDialog.tsx:52 (the derivation is visible on the next line) and the first sentence of ChatSearchDialog.tsx:151 ("Debounce filters and free text as one snapshot" narrates the call; only the second sentence, the why, earns its line). Minor consistency: the new code uses (previous) and (filter) at lines 284/288 where the file convention is (prev) and (f).

🤖

Fixed. Deleted the const buildQuery = buildChatSearchQuery alias and its stale comment; the call site uses buildChatSearchQuery directly. Also trimmed the redundant KNOWN_FILTER_KEYS derivation comment and the narrative first sentence of the debounce comment (kept the why), and aligned the new code to the file's prev/f naming convention.

🤖 Coder Agents

P2 [CRF-20] queryInput is a fresh object literal every render, so useDebouncedValue's correctness now rests entirely on React Compiler memoization, a dependency that is invisible at the call site. (Komugi P1, Netero P2, Pariston P2, Leorio P2, Takumi P2, Hisoka Note, Mafuuu Note, Nami Note, Meruem Note)

useDebouncedValue's effect keys on [value, debounceTimeoutMs] and compares by reference (site/src/hooks/debounce.ts:112). The R1 code debounced a primitive (freeText) and a useMemo'd array (effectiveFilters); this commit deleted the memo and the import. Uncompiled, the behavior is verified by four independent probe harnesses: the timer fires, setDebouncedValue stores a fresh identity, the render mints another queryInput, the effect re-arms, and the loop self-sustains at one render per 500ms for as long as the dialog is open. Worse, every unrelated render resets the pending timer: Komugi traced ChatsSidebar.tsx:168 passing the live chats array as recentChats, so with an agent actively streaming, sidebar re-renders arriving faster than 500ms starve the debounce entirely and the search never fires until the stream pauses.

The panel verified the mitigating fence: vite.config.mts opts src/pages/AgentsPage/ into babel-plugin-react-compiler, three reviewers compiled this file and confirmed the compiler memoizes queryInput on [filters, freeText, incompleteFilterKey], and pnpm lint:compiler (part of make lint) fails on any bailout in those directories. So as shipped, the loop does not run. The severity disagreement is about the residual state: the pattern looks copy-pasteable, and outside the compiled directories (or under a "use no memo" bailout) it degrades into the loop with no local signal. site/AGENTS.md forbids manual useMemo in this directory, so the fix is not "restore the memo" against convention; the honest options are a short comment at the call site naming the compiler dependency, or restructuring so the debounced value is a primitive (e.g. debounce a joined key or the built query string). At minimum, the next person to copy this pattern elsewhere needs the warning.

🤖

Fixed. The debounced value is now a primitive string snapshot (the emitted query with a 1/0 hasSearchText prefix), not a fresh object literal, so useDebouncedValue's reference comparison no longer depends on React Compiler memoizing queryInput. The atomic-debounce property (no stale incomplete-filter leak) is preserved, and the CommittedFilterDoesNotLeakStaleText story covers it.

🤖 Coder Agents

Note [CRF-35] Clearing free text while a filter pill is active leaves the stale search: token in the query for one debounce period; the old code zeroed it immediately. (Takumi)

Round 1's queryFreeText = incompleteFilterKey || !freeText.trim() ? "" : debouncedFreeText short-circuited cleared text past the debounce. Now the empty text rides the 500ms snapshot debounce, so with a pill active the previous text's results (and hasSearchText, which gates the indexing-lag copy) linger for up to 500ms after deletion. It converges, and symmetric debounce on deletion is defensible, so this is informational. The commit-a-filter case the snapshot comment targets is genuinely atomic and correct.

🤖

Acknowledged. Symmetric debounce on deletion is the deliberate tradeoff here: clearing free text now rides the same 500ms snapshot debounce rather than zeroing immediately, so results (and hasSearchText) linger briefly. It converges and keeps the snapshot atomic. Accepting as-is; thanks for calling out the distinction from the commit-a-filter path.

🤖 Coder Agents

P3 [CRF-25] When space triggers typed-filter extraction and the consumed token is not the last token, the typed space is swallowed and the next keystroke glues onto the preceding word. (Netero P3, Mafuuu P3, Nami P3)

The handler calls event.preventDefault(), so the space is never inserted; the only way it survives is needsTrailingSeparator (searchQuery.ts:141-142), which appends a separator only when the consumed token is the last one. Paste has_unread:true fix (paste bypasses keydown extraction), then press space: the pill extracts, remainingText is "fix" with no trailing space, and typing auth produces fixauth, emitted as search:"fixauth". This is the sibling of the mid-string separator bug the PR notes claim fixed; that fix covers inter-token separators but not the just-typed space when a trailing token survives. Nami adds a second edge: extraction fires regardless of cursor position, and setFreeText(remainingText) resets the cursor to the end, so mid-string edits teleport the caret. Fix: on event.key === " ", append the separator whenever remainingText is non-empty, and consider running extraction only when the cursor is at the end of the input.

🤖

Fixed. On a Space trigger, the separator is appended whenever the remaining text is non-empty, so the next keystroke no longer glues onto the preceding word. Extraction also only runs when the caret is at the end of the input, which avoids the caret-teleport on mid-string edits.

🤖 Coder Agents