Skip to content

chore(scripts/releaser): remove GPG signing key check #27422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f0ssel merged 1 commit into from
Jul 24, 2026
+12 −38
Merged

chore(scripts/releaser): remove GPG signing key check #27422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions scripts/releaser/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (
// here. Safe operations (file writes, fetches, editor) are
// called directly.
type ReleaseExecutor interface {
// CreateTag creates an annotated (optionally signed) git tag.
CreateTag(ctx context.Context, tag, ref, message string, sign bool) error
// CreateTag creates an annotated git tag.
CreateTag(ctx context.Context, tag, ref, message string) error
// PushTag pushes a tag to the origin remote.
PushTag(ctx context.Context, tag string) error
// TriggerWorkflow dispatches the release.yaml GitHub Actions
Expand All @@ -30,14 +30,8 @@ type ReleaseExecutor interface {
// liveExecutor performs real operations.
type liveExecutor struct{}

//nolint:revive // sign flag is part of the ReleaseExecutor interface contract.
func (e *liveExecutor) CreateTag(_ context.Context, tag, ref, message string, sign bool) error {
args := []string{"tag", "-a"}
if sign {
args = append(args, "-s")
}
args = append(args, tag, "-m", message, ref)
return gitRun(args...)
func (*liveExecutor) CreateTag(_ context.Context, tag, ref, message string) error {
return gitRun("tag", "-a", tag, "-m", message, ref)
}

func (*liveExecutor) PushTag(_ context.Context, tag string) error {
Expand Down Expand Up @@ -70,13 +64,8 @@ type dryRunExecutor struct {
w io.Writer
}

//nolint:revive // sign flag is part of the ReleaseExecutor interface contract.
func (e *dryRunExecutor) CreateTag(_ context.Context, tag, ref, message string, sign bool) error {
signFlag := ""
if sign {
signFlag = "-s "
}
_, _ = fmt.Fprintf(e.w, "[DRYRUN] would run: git tag %s-a %s -m %q %s\n", signFlag, tag, message, ref)
func (e *dryRunExecutor) CreateTag(_ context.Context, tag, ref, message string) error {
_, _ = fmt.Fprintf(e.w, "[DRYRUN] would run: git tag -a %s -m %q %s\n", tag, message, ref)
return nil
}

Expand Down
4 changes: 2 additions & 2 deletions scripts/releaser/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
)

//nolint:revive // Long function is fine for a sequential release flow.
func runRelease(ctx context.Context, inv *serpent.Invocation, executor ReleaseExecutor, ghAvailable, gpgConfigured, dryRun bool) error {
func runRelease(ctx context.Context, inv *serpent.Invocation, executor ReleaseExecutor, ghAvailable, dryRun bool) error {
w := inv.Stderr

// --- Release landscape ---
Expand Down Expand Up @@ -767,7 +767,7 @@ func runRelease(ctx context.Context, inv *serpent.Invocation, executor ReleaseEx
if err := confirm(inv, "Create tag?"); err != nil {
return xerrors.New("cannot proceed without a tag")
}
if err := executor.CreateTag(ctx, newVersion.String(), ref, "Release "+newVersion.String(), gpgConfigured); err != nil {
if err := executor.CreateTag(ctx, newVersion.String(), ref, "Release "+newVersion.String()); err != nil {
return xerrors.Errorf("creating tag: %w", err)
}
successf(w, "Tag %s created.", newVersion)
Expand Down
23 changes: 4 additions & 19 deletions scripts/releaser/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (

"golang.org/x/xerrors"

"github.com/coder/coder/v2/cli/cliui"
"github.com/coder/serpent"
)

Expand All @@ -17,10 +16,9 @@ const (

// Run executes the interactive release wizard.
//
// It verifies dependencies, warns when GPG signing or the gh CLI are not
// configured, wires up a live or dry-run executor, and then walks the
// operator through tagging, pushing, and triggering the release
// workflow.
// It verifies dependencies, warns when the gh CLI is not configured, wires
// up a live or dry-run executor, and then walks the operator through
// tagging, pushing, and triggering the release workflow.
//
//nolint:revive // dryRun selects the dry-run executor for the wizard.
func Run(inv *serpent.Invocation, dryRun bool) error {
Expand All @@ -32,19 +30,6 @@ func Run(inv *serpent.Invocation, dryRun bool) error {
return xerrors.New("git is required but not found in PATH")
}

// --- Check GPG signing ---
signingKey, _ := gitOutput("config", "--get", "user.signingkey")
gpgFormat, _ := gitOutput("config", "--get", "gpg.format")
gpgConfigured := signingKey != "" || gpgFormat != ""
if !gpgConfigured {
warnf(w, "GPG signing is not configured. Tags will be unsigned, so there will be no way to verify who pushed the tag.")
_, _ = fmt.Fprintf(w, " To fix: set git config user.signingkey or gpg.format\n")
if err := confirmWithDefault(inv, "Continue without signing?", cliui.ConfirmNo); err != nil {
return err
}
_, _ = fmt.Fprintln(w)
}

// --- Check gh CLI auth ---
ghAvailable := checkGHAuth()
if !ghAvailable {
Expand All @@ -62,5 +47,5 @@ func Run(inv *serpent.Invocation, dryRun bool) error {
executor = &liveExecutor{}
}

return runRelease(ctx, inv, executor, ghAvailable, gpgConfigured, dryRun)
return runRelease(ctx, inv, executor, ghAvailable, dryRun)
}
Loading