chore: remove releaser v2 flow and drop v1 naming - #27421
Merged
Merged
Conversation
f0ssel
changed the title
f0ssel
force-pushed
the
remove-releaser-v2
branch
from
July 23, 2026 17:50
3e31eb1 to
0a24a07
Compare
f0ssel
marked this pull request as ready for review
July 23, 2026 18:36
Make the interactive release wizard the only release path. - Delete .github/workflows/tag-and-release.yaml and scripts/releaser/v2. - Move scripts/releaser/v1 into scripts/releaser (package main) and drop the --legacy flag and v2 subcommands from main.go. - Update scripts/release.sh to invoke the wizard directly.
f0ssel
force-pushed
the
remove-releaser-v2
branch
from
July 23, 2026 18:43
0a24a07 to
bb1f2d6
Compare
Member
Author
|
@mtojek I originally went down the road of making this a github action flow and the UX was just not good. We never used this outside of testing so it's OK to rip out. |
BobbyHo
approved these changes
Jul 24, 2026
## Summary Removes the GPG signing key check from the release wizard. The preflight check warned and prompted "Continue without signing?" when GPG signing was not configured, and the same `gpgConfigured` value gated whether the release tag was signed. Both are removed; release tags are now plain annotated tags (`git tag -a`). ## Changes - Remove the GPG preflight check and `gpgConfigured` plumbing from `run.go` and `runRelease` in `release.go`. - Drop the `sign` parameter from `ReleaseExecutor.CreateTag` and both implementations (`liveExecutor` no longer appends `-s`). ## Validation - `go build ./scripts/releaser/...` - `go test ./scripts/releaser/...` - `go vet` + `golangci-lint run ./scripts/releaser/...` - `gofmt -l` clean > [!IMPORTANT] > Stacked on top of #27421 (base branch `remove-releaser-v2`). Review/merge that PR first, then retarget this one to `main`. --- Generated by Coder Agents on behalf of @f0ssel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the GitHub Actions-driven releaser v2 pipeline so the interactive release wizard is the only release path, and drops the
v1naming now that it is the sole implementation.Changes
.github/workflows/tag-and-release.yaml(the v2 workflow).scripts/releaser/v2/.scripts/releaser/v1/intoscripts/releaser/aspackage main.scripts/releaser/main.goto a single wizard command: drop the--legacyflag and the v2rc/branch/releasesubcommands and hidden CI compat commands.--dry-runis preserved.scripts/release.shto rungo run ./scripts/releaser "$@"(no--legacy).The legacy
release.yamlworkflow (triggered byscripts/release.sh) is unchanged and remains the release pipeline.Validation
go build ./scripts/releaser/...go test ./scripts/releaser/...go vet+golangci-lint run ./scripts/releaser/...gofmt -lcleanNote
The GPG signing key check removal is handled in a stacked follow-up PR based on this branch.
Implementation plan
scripts/releaser/v2/+.github/workflows/tag-and-release.yaml(usesgo run ./scripts/releaser prepare-release|generate-notes).v2was imported only bymain.go; the workflow was referenced nowhere else.scripts/releaser/v1/, reached via--legacy, drivingrelease.yaml(triggered byscripts/release.sh).docs/referenced the releaser tool or these workflows.v1/*up toscripts/releaser/(package main, including test files); rewritemain.goto a single wizard command; updaterelease.sh.Generated by Coder Agents on behalf of @f0ssel.